[JENKINS-18884] Add People View #9052

hypery2k · 2024-03-19T17:55:16Z

See JENKINS-18884. And People page of All view also displays all users registered in Jenkins.

Testing done

Proposed changelog entries

Adds permission check to jobs to extract users (now requires Read permission).
People page of All view no longer display all users registered in Jenkins. It works same as those of other views:
There is no reason for People page of All page to work different from those of other views.
Displaying all users in Jenkins should be handled by security realms (like HudsonPrivateSecurityRealm.ManageUserLinks).
This is another approach of [JENKINS-18884] Added configuration for access to "People" page. #1094 .

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.

The Jira issue, if it exists, is well-described.
Options
Successfully updated the issue's project

There was an error updating the issue's project
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see [examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)). Fill in the **Proposed upgrade guidelines** section only if there are breaking changes or changes that may require extra steps from users during upgrade.

The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
Options
Successfully updated the issue's project

There was an error updating the issue's project
There is automated testing or an explanation as to why this change has no tests.

There is automated testing or an explanation as to why this change has no tests.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New public classes, fields, and methods are annotated with `@Restricted` or have `@since TODO` Javadocs, as appropriate.

New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New deprecations are annotated with `@Deprecated(since = "TODO")` or `@Deprecated(forRemoval = true, since = "TODO")`, if applicable.

New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New or substantially changed JavaScript is not defined inline and does not call `eval` to ease future introduction of Content Security Policy (CSP) directives (see [documentation](https://www.jenkins.io/doc/developer/security/csp/)).

New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
Options
Successfully updated the issue's project

There was an error updating the issue's project
For dependency updates, there are links to external changelogs and, if possible, full differentials.

For dependency updates, there are links to external changelogs and, if possible, full differentials.
Options
Successfully updated the issue's project

There was an error updating the issue's project
For new APIs and extension points, there is a link to at least one consumer.

For new APIs and extension points, there is a link to at least one consumer.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.

Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Changelog entries in the pull request title and/or **Proposed changelog entries** are accurate, human-readable, and in the imperative mood.

Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Proper changelog labels are set so that the changelog can be generated automatically.

Proper changelog labels are set so that the changelog can be generated automatically.
Options
Successfully updated the issue's project

There was an error updating the issue's project
If the change needs additional upgrade steps from users, the `upgrade-guide-needed` label is set and there is a **Proposed upgrade guidelines** section in the pull request title (see [example](https://github.com/jenkinsci/jenkins/pull/4387)).

If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
Options
Successfully updated the issue's project

There was an error updating the issue's project
If it would make sense to backport the change to LTS, a Jira issue must exist, be a _Bug_ or _Improvement_, and be labeled as `lts-candidate` to be considered (see [query](https://issues.jenkins.io/issues/?filter=12146)).

If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

github-actions · 2024-03-19T17:59:14Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

see https://issues.jenkins-ci.org/browse/JENKINS-18884

daniel-beck · 2024-03-19T18:48:00Z

Previously: #1094 and #1102 (which this resurrects almost exactly).

Could you explain what this PR is supposed to do? I am asking because it doesn't actually do what the title says, and likely not what at least a subset of people in the linked issue need.

Are there reasons you decided against implementing the suggestions from #1102 (comment) / #1102 (comment) / #1102 (comment) / #1102 (comment)?

FWIW I would currently prefer a removal from core (no implicit dependency) with simultaneous release of a replacement plugin, similar to https://plugins.jenkins.io/cctray-xml/

hypery2k · 2024-03-22T14:37:18Z

basically I just tried to get past work done and resolve the mentioned issue. For extracting to a new plugin somebody else has to takeover, i can not handle that.
If the team is preferring that solution you can close this MR

daniel-beck · 2024-03-22T15:25:10Z

extracting to a new plugin somebody else has to takeover, i can not handle that

FTR #9060 but note that it may not work out (or may not be a consensus preferred approach).

MarkEWaite · 2024-03-27T16:55:40Z

Closing this pull request since it has been superseded by

[JENKINS-18884] Remove 'People' view #9060

Thanks very much @hypery2k

hypery2k mentioned this pull request Mar 19, 2024

[FIXED JENKINS-18884] Access check to jobs in People pages. #1102

Closed

github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Mar 19, 2024

hypery2k added 6 commits March 19, 2024 19:30

Feature: View of users requiring overall read permission

476c6fb

see https://issues.jenkins-ci.org/browse/JENKINS-18884

Fix test errors

4925339

Test: Fix typo in test resource name

cdcb0e7

Test: Fix test setup errors

04d669c

Permissions adding user info permission checks

1c17f9f

chore: Adding EOL in test config XML

2f5c5c1

hypery2k force-pushed the feature/JENKINS-18884_people-user-listing branch from 5c63b72 to 2f5c5c1 Compare March 19, 2024 18:31

github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Mar 19, 2024

chore: Fix merge error

e691203

fix: Drop legacy api usages

183180f

daniel-beck mentioned this pull request Mar 21, 2024

[JENKINS-18884] Remove 'People' view #9060

Merged

hypery2k changed the title ~~[JENKINS-18884] Seperate Permission for People View~~ [JENKINS-18884] Add People View Mar 22, 2024

Merge branch 'master' into feature/JENKINS-18884_people-user-listing

dd9c297

MarkEWaite closed this Mar 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-18884] Add People View #9052

[JENKINS-18884] Add People View #9052

hypery2k commented Mar 19, 2024 •

edited

Submitter checklist

Maintainer checklist

github-actions bot commented Mar 19, 2024

daniel-beck commented Mar 19, 2024 •

edited

hypery2k commented Mar 22, 2024

daniel-beck commented Mar 22, 2024

MarkEWaite commented Mar 27, 2024

[JENKINS-18884] Add People View #9052

[JENKINS-18884] Add People View #9052

Conversation

hypery2k commented Mar 19, 2024 • edited

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

github-actions bot commented Mar 19, 2024

daniel-beck commented Mar 19, 2024 • edited

hypery2k commented Mar 22, 2024

daniel-beck commented Mar 22, 2024

MarkEWaite commented Mar 27, 2024

hypery2k commented Mar 19, 2024 •

edited

daniel-beck commented Mar 19, 2024 •

edited