[JENKINS-18884] Remove 'People' view #9060

daniel-beck · 2024-03-21T22:13:37Z

See JENKINS-18884 and #9052 (comment) for previous context. This is the core change corresponding to the creation of a new plugin as suggested in the linked comment.

Plugin sketch: https://github.com/daniel-beck/people-view-plugin

Usage check

A quick GH search indicates just two affected plugins:

https://plugins.jenkins.io/graphql-server/ (recently disowned)
https://plugins.jenkins.io/jabber-server-plugin/ (last released in 2014, unresolved vulnerability).

usage-in-plugins only finds jabber-server-plugin.

As -M and -C:

hudson/model/View$People
hudson/model/View$AsynchPeople
hudson/model/View$AsynchPeople$People
hudson.model.View#getAsynchPeople
hudson.model.View#getPeople
hudson.model.View#hasPeople
jenkins.model.Jenkins#getAsynchPeople
jenkins.model.Jenkins#getPeople
jenkins.model.Jenkins#hasPeople

Result

jabber-server-plugin:1.9
Classes
hudson/model/View$People
Methods
jenkins/model/Jenkins#getPeople()Lhudson/model/View$People;

Testing done

Navigated to /people/ and /asynchPeople/, saw the new placeholder page.

Ran https://github.com/daniel-beck/people-view-plugin/ as of daniel-beck/people-view-plugin@3bd4f1d and confirmed I'm seeing the plugin-contributed views.

Proposed changelog entries

Remove "People" view. Administrators can install the new People View plugin to restore this functionality.

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.

The Jira issue, if it exists, is well-described.
Options
Successfully updated the issue's project

There was an error updating the issue's project
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see [examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)). Fill in the **Proposed upgrade guidelines** section only if there are breaking changes or changes that may require extra steps from users during upgrade.

The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
Options
Successfully updated the issue's project

There was an error updating the issue's project
There is automated testing or an explanation as to why this change has no tests.

There is automated testing or an explanation as to why this change has no tests.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New public classes, fields, and methods are annotated with `@Restricted` or have `@since TODO` Javadocs, as appropriate.

New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New deprecations are annotated with `@Deprecated(since = "TODO")` or `@Deprecated(forRemoval = true, since = "TODO")`, if applicable.

New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New or substantially changed JavaScript is not defined inline and does not call `eval` to ease future introduction of Content Security Policy (CSP) directives (see [documentation](https://www.jenkins.io/doc/developer/security/csp/)).

New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
Options
Successfully updated the issue's project

There was an error updating the issue's project
For dependency updates, there are links to external changelogs and, if possible, full differentials.

For dependency updates, there are links to external changelogs and, if possible, full differentials.
Options
Successfully updated the issue's project

There was an error updating the issue's project
For new APIs and extension points, there is a link to at least one consumer.

For new APIs and extension points, there is a link to at least one consumer.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.

Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Changelog entries in the pull request title and/or **Proposed changelog entries** are accurate, human-readable, and in the imperative mood.

Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Proper changelog labels are set so that the changelog can be generated automatically.

Proper changelog labels are set so that the changelog can be generated automatically.
Options
Successfully updated the issue's project

There was an error updating the issue's project
If the change needs additional upgrade steps from users, the `upgrade-guide-needed` label is set and there is a **Proposed upgrade guidelines** section in the pull request title (see [example](https://github.com/jenkinsci/jenkins/pull/4387)).

If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
Options
Successfully updated the issue's project

There was an error updating the issue's project
If it would make sense to backport the change to LTS, a Jira issue must exist, be a _Bug_ or _Improvement_, and be labeled as `lts-candidate` to be considered (see [query](https://issues.jenkins.io/issues/?filter=12146)).

If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

daniel-beck · 2024-03-21T23:03:57Z

core/src/main/resources/hudson/model/View/sidepanel.jelly

-        <j:when test="${it.class.name=='hudson.model.AllView'}">
-          <l:task href="${rootURL}/asynchPeople/" icon="icon-user icon-md" title="${%People}"/>
-        </j:when>


FTR this is a bug IMO, as AllView can exist in folders. Note how https://weekly.ci.jenkins.io/job/folder/ links to /asynchPeople/.

daniel-beck · 2024-03-21T23:05:40Z

core/src/main/resources/hudson/model/User/sidepanel.jelly

@@ -31,7 +31,6 @@ THE SOFTWARE.
  <l:header />
  <l:side-panel>
    <l:tasks>
-      <l:task contextMenu="false" href="${rootURL}/asynchPeople/" icon="symbol-people" title="${%People}"/>


This is an awkward case as the people view basically represents the list of users, of which an individual user is an entry (which is why this is the first link in the sidepanel). Unless using the built-in Jenkins' own user database, admins no longer have a users list with this change. We should probably add a ManagementLink before long to iterate over (actual) users.

Unless using the built-in Jenkins' own user database, admins no longer have a users list with this change.

They do not have such a list currently. AsynchPeople lists SCM users which are not in the security realm; and does not list users which are in the security realm but have no user record on disk. It is simply useless for this purpose.

but have no user record on disk

Right, but anyone who's logged in once has such a record, which makes it a viable (if crappy and slow) entrypoint to getting to someone that's not directly entering the URL.

jglick · 2024-03-22T19:13:40Z

core/src/main/resources/hudson/model/User/sidepanel.jelly

@@ -31,7 +31,6 @@ THE SOFTWARE.
  <l:header />
  <l:side-panel>
    <l:tasks>
-      <l:task contextMenu="false" href="${rootURL}/asynchPeople/" icon="symbol-people" title="${%People}"/>


Unless using the built-in Jenkins' own user database, admins no longer have a users list with this change.

They do not have such a list currently. AsynchPeople lists SCM users which are not in the security realm; and does not list users which are in the security realm but have no user record on disk. It is simply useless for this purpose.

core/src/main/java/jenkins/model/PeopleRedirect.java

test/src/test/java/jenkins/security/stapler/GetterMethodFilterTest.java

It's not entirely clear what this test signifies, given the existence of `testTopLevelItemIsLegal`, but whatever.

jglick · 2024-03-25T13:51:00Z

core/src/main/resources/jenkins/model/PeopleRedirect/index.properties

@@ -0,0 +1 @@
+blurb = The "People" view has been moved into the <a href="https://plugins.jenkins.io/people-view" target="_blank" rel="noopener noreferrer">People View</a> plugin.


Suggested change

blurb = The "People" view has been moved into the <a href="https://plugins.jenkins.io/people-view" target="_blank" rel="noopener noreferrer">People View</a> plugin.

blurb = The "People" view has been moved into the <a href="https://plugins.jenkins.io/people-view/" target="_blank" rel="noopener noreferrer">People View</a> plugin.

MarkEWaite · 2024-03-27T15:14:09Z

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

[JENKINS-18884] Remove 'People' view

3aa7f4c

daniel-beck commented Mar 21, 2024

View reviewed changes

Add placeholder pages when someone tries to access removed URLs

561c044

daniel-beck mentioned this pull request Mar 22, 2024

[JENKINS-18884] Add People View #9052

Closed

Remove obsolete UserInfo class, inapplicable tests

84bff44

jglick reviewed Mar 22, 2024

View reviewed changes

Restore test with a different core-contributed object

6254bf3

It's not entirely clear what this test signifies, given the existence of `testTopLevelItemIsLegal`, but whatever.

daniel-beck marked this pull request as ready for review March 22, 2024 22:52

Remove probably unnecessary code

aaea770

daniel-beck mentioned this pull request Mar 23, 2024

[JENKINS-18884] People View plugin jenkins-infra/repository-permissions-updater#3830

Closed

jglick approved these changes Mar 25, 2024

View reviewed changes

NotMyFault approved these changes Mar 26, 2024

View reviewed changes

MarkEWaite self-assigned this Mar 27, 2024

MarkEWaite added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise removed This PR removes a feature or a public API labels Mar 27, 2024

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 27, 2024

MarkEWaite merged commit 28ed39d into jenkinsci:master Mar 28, 2024
17 checks passed

daniel-beck deleted the JENKINS-18884 branch March 28, 2024 21:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-18884] Remove 'People' view #9060

[JENKINS-18884] Remove 'People' view #9060

daniel-beck commented Mar 21, 2024 •

edited

Submitter checklist

Maintainer checklist

daniel-beck Mar 21, 2024

daniel-beck Mar 21, 2024 •

edited

jglick Mar 22, 2024

daniel-beck Mar 22, 2024

jglick Mar 22, 2024

jglick Mar 25, 2024

MarkEWaite commented Mar 27, 2024

		@@ -0,0 +1 @@
		blurb = The "People" view has been moved into the <a href="https://plugins.jenkins.io/people-view" target="_blank" rel="noopener noreferrer">People View</a> plugin.

[JENKINS-18884] Remove 'People' view #9060

[JENKINS-18884] Remove 'People' view #9060

Conversation

daniel-beck commented Mar 21, 2024 • edited

Usage check

Result

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

daniel-beck Mar 21, 2024

Choose a reason for hiding this comment

daniel-beck Mar 21, 2024 • edited

Choose a reason for hiding this comment

jglick Mar 22, 2024

Choose a reason for hiding this comment

daniel-beck Mar 22, 2024

Choose a reason for hiding this comment

jglick Mar 22, 2024

Choose a reason for hiding this comment

jglick Mar 25, 2024

Choose a reason for hiding this comment

MarkEWaite commented Mar 27, 2024

daniel-beck commented Mar 21, 2024 •

edited

daniel-beck Mar 21, 2024 •

edited