chore: convert to TS #305
Merged
chore: convert to TS #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Jul 17, 2019
|
@SimenB you're welcome to rebase them - I suspect you're better at it anyway 馃槈 Right now I'm busy trying to figure out how to make a |
|
Cool, I'll rebase all of your open PRs, then 馃檪 I'll ping you if tests fail in any of them and they're not trivial to fix |
SimenB
force-pushed
the
reapply-ts
branch
3 times, most recently
from
3a2687e
to
68c2d89
Compare
|
馃帀 This PR is included in version 22.13.1 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2 of the TS migration.
Needs to wait for typescript-eslint/typescript-eslint#712 to avoid peer dep warning when installing this, but I think this now works beyond that 馃檪~^ is released as canary. We should either wait for a stable or their next major, then we can merge this 馃 ~
^ Out as 1.13, will merge this
/cc @jeysal