chore: convert to TS

.eslintrc.js

@@ -3,13 +3,20 @@
 const { globals } = require('./').environments.globals;
 
 module.exports = {
+  parser: '@typescript-eslint/parser',
   extends: [
-    'eslint:recommended',
     'plugin:eslint-plugin/recommended',
     'plugin:node/recommended',
+    'plugin:@typescript-eslint/eslint-recommended',
     'prettier',
   ],
-  plugins: ['eslint-plugin', 'node', 'prettier', 'import'],
+  plugins: [
+    'eslint-plugin',
+    'node',
+    'prettier',
+    'import',
+    '@typescript-eslint',
+  ],
   parserOptions: {
     ecmaVersion: 2018,
   },
@@ -35,7 +42,7 @@ module.exports = {
   },
   overrides: [
     {
-      files: ['*.test.js'],
+      files: ['*.test.js', '*.test.ts'],
       globals,
     },
     {

.gitignore

@@ -1,3 +1,4 @@
 node_modules/
 coverage/
 lib/
+*.log

.travis.yml

@@ -13,6 +13,7 @@ script:
 - yarn commitlint --from="$TRAVIS_BRANCH" --to="$TRAVIS_COMMIT"
 - yarn commitlint --from=$TRAVIS_COMMIT
 - yarn prettylint
+- yarn typecheck
 - yarn test --coverage --maxWorkers 2
 after_script: greenkeeper-lockfile-upload
 jobs:

babel.config.js

@@ -1,5 +1,8 @@
 'use strict';
 
 module.exports = {
-  presets: [['@babel/preset-env', { targets: { node: 6 } }]],
+  presets: [
+    '@babel/preset-typescript',
+    ['@babel/preset-env', { targets: { node: 6 } }],
+  ],
 };

package.json

@@ -27,19 +27,30 @@
   },
   "scripts": {
     "prepare": "yarn build && yarn postbuild",
-    "lint": "eslint . --ignore-pattern '!.eslintrc.js'",
+    "lint": "eslint . --ignore-pattern '!.eslintrc.js' --ext js,ts",
     "prettylint": "prettylint docs/**/*.md README.md package.json",
     "prepublishOnly": "yarn build",
+    "pretest": "yarn build",
     "test": "jest",
-    "build": "babel src --out-dir lib",
-    "postbuild": "rimraf lib/**/__tests__/**"
+    "build": "babel --extensions .js,.ts src --out-dir lib",
+    "postbuild": "rimraf lib/**/__tests__/**",
+    "typecheck": "tsc -p ."
+  },
+  "dependencies": {
+    "@typescript-eslint/experimental-utils": "^1.13.0"
   },
   "devDependencies": {
     "@babel/cli": "^7.4.4",
     "@babel/core": "^7.4.4",
     "@babel/preset-env": "^7.4.4",
+    "@babel/preset-typescript": "^7.3.3",
     "@commitlint/cli": "^6.0.0",
     "@commitlint/config-conventional": "^6.0.0",
+    "@types/eslint": "^4.16.6",
+    "@types/jest": "^24.0.15",
+    "@types/node": "^12.6.6",
+    "@typescript-eslint/eslint-plugin": "^1.13.0",
+    "@typescript-eslint/parser": "^1.13.0",
     "babel-eslint": "^10.0.2",
     "babel-jest": "^24.8.0",
     "eslint": "^5.1.0",
@@ -54,15 +65,16 @@
     "lint-staged": "^8.0.4",
     "prettier": "^1.10.2",
     "prettylint": "^1.0.0",
-    "rimraf": "^2.6.3"
+    "rimraf": "^2.6.3",
+    "typescript": "^3.5.3"
   },
   "prettier": {
     "proseWrap": "always",
     "singleQuote": true,
     "trailingComma": "all"
   },
   "lint-staged": {
-    "*.js": [
+    "*.{js,ts}": [
       "eslint --fix",
       "git add"
     ],

src/index.js

@@ -13,8 +13,16 @@ function importDefault(moduleName) {
 }
 
 const rules = readdirSync(join(__dirname, 'rules'))
-  .filter(rule => rule !== '__tests__' && rule !== 'util.js')
-  .map(rule => basename(rule, '.js'))
+  .filter(
+    rule =>
+      rule !== '__tests__' &&
+      rule !== 'util.js' &&
+      rule !== 'tsUtils.ts' &&
+      rule !== 'tsUtils.js',
+  )
+  .map(rule =>
+    rule.endsWith('js') ? basename(rule, '.js') : basename(rule, '.ts'),
+  )
   .reduce(
     (acc, curr) =>
       Object.assign(acc, { [curr]: importDefault(`./rules/${curr}`) }),

src/rules/__tests__/consistent-test-it.test.js → src/rules/__tests__/consistent-test-it.test.ts

@@ -1,7 +1,7 @@
-import { RuleTester } from 'eslint';
+import { TSESLint } from '@typescript-eslint/experimental-utils';
 import rule from '../consistent-test-it';
 
-const ruleTester = new RuleTester({
+const ruleTester = new TSESLint.RuleTester({
   parserOptions: {
     ecmaVersion: 6,
   },

src/rules/__tests__/expect-expect.test.js → src/rules/__tests__/expect-expect.test.ts

@@ -1,7 +1,10 @@
-import { RuleTester } from 'eslint';
+import {
+  AST_NODE_TYPES,
+  TSESLint,
+} from '@typescript-eslint/experimental-utils';
 import rule from '../expect-expect';
 
-const ruleTester = new RuleTester({
+const ruleTester = new TSESLint.RuleTester({
   parserOptions: {
     ecmaVersion: 6,
   },
@@ -37,7 +40,7 @@ ruleTester.run('expect-expect', rule, {
       errors: [
         {
           messageId: 'noAssertions',
-          type: 'CallExpression',
+          type: AST_NODE_TYPES.CallExpression,
         },
       ],
     },
@@ -46,7 +49,7 @@ ruleTester.run('expect-expect', rule, {
       errors: [
         {
           messageId: 'noAssertions',
-          type: 'CallExpression',
+          type: AST_NODE_TYPES.CallExpression,
         },
       ],
     },
@@ -55,7 +58,7 @@ ruleTester.run('expect-expect', rule, {
       errors: [
         {
           messageId: 'noAssertions',
-          type: 'CallExpression',
+          type: AST_NODE_TYPES.CallExpression,
         },
       ],
     },
@@ -65,7 +68,7 @@ ruleTester.run('expect-expect', rule, {
       errors: [
         {
           messageId: 'noAssertions',
-          type: 'CallExpression',
+          type: AST_NODE_TYPES.CallExpression,
         },
       ],
     },
@@ -75,7 +78,7 @@ ruleTester.run('expect-expect', rule, {
       errors: [
         {
           messageId: 'noAssertions',
-          type: 'CallExpression',
+          type: AST_NODE_TYPES.CallExpression,
         },
       ],
     },

src/rules/__tests__/lowercase-name.test.js → src/rules/__tests__/lowercase-name.test.ts

@@ -1,7 +1,8 @@
-import { RuleTester } from 'eslint';
+import { TSESLint } from '@typescript-eslint/experimental-utils';
 import rule from '../lowercase-name';
+import { DescribeAlias, TestCaseName } from '../tsUtils';
 
-const ruleTester = new RuleTester({
+const ruleTester = new TSESLint.RuleTester({
   parserOptions: {
     ecmaVersion: 6,
   },
@@ -54,7 +55,7 @@ ruleTester.run('lowercase-name', rule, {
       errors: [
         {
           messageId: 'unexpectedLowercase',
-          data: { method: 'it' },
+          data: { method: TestCaseName.it },
           column: 1,
           line: 1,
         },
@@ -66,7 +67,7 @@ ruleTester.run('lowercase-name', rule, {
       errors: [
         {
           messageId: 'unexpectedLowercase',
-          data: { method: 'it' },
+          data: { method: TestCaseName.it },
           column: 1,
           line: 1,
         },
@@ -78,7 +79,7 @@ ruleTester.run('lowercase-name', rule, {
       errors: [
         {
           messageId: 'unexpectedLowercase',
-          data: { method: 'it' },
+          data: { method: TestCaseName.it },
           column: 1,
           line: 1,
         },
@@ -90,7 +91,7 @@ ruleTester.run('lowercase-name', rule, {
       errors: [
         {
           messageId: 'unexpectedLowercase',
-          data: { method: 'test' },
+          data: { method: TestCaseName.test },
           column: 1,
           line: 1,
         },
@@ -102,7 +103,7 @@ ruleTester.run('lowercase-name', rule, {
       errors: [
         {
           messageId: 'unexpectedLowercase',
-          data: { method: 'test' },
+          data: { method: TestCaseName.test },
           column: 1,
           line: 1,
         },
@@ -114,7 +115,7 @@ ruleTester.run('lowercase-name', rule, {
       errors: [
         {
           messageId: 'unexpectedLowercase',
-          data: { method: 'test' },
+          data: { method: TestCaseName.test },
           column: 1,
           line: 1,
         },
@@ -126,7 +127,7 @@ ruleTester.run('lowercase-name', rule, {
       errors: [
         {
           messageId: 'unexpectedLowercase',
-          data: { method: 'describe' },
+          data: { method: DescribeAlias.describe },
           column: 1,
           line: 1,
         },
@@ -138,7 +139,7 @@ ruleTester.run('lowercase-name', rule, {
       errors: [
         {
           messageId: 'unexpectedLowercase',
-          data: { method: 'describe' },
+          data: { method: DescribeAlias.describe },
           column: 1,
           line: 1,
         },
@@ -150,7 +151,7 @@ ruleTester.run('lowercase-name', rule, {
       errors: [
         {
           messageId: 'unexpectedLowercase',
-          data: { method: 'describe' },
+          data: { method: DescribeAlias.describe },
           column: 1,
           line: 1,
         },
@@ -162,7 +163,7 @@ ruleTester.run('lowercase-name', rule, {
       errors: [
         {
           messageId: 'unexpectedLowercase',
-          data: { method: 'describe' },
+          data: { method: DescribeAlias.describe },
           column: 1,
           line: 1,
         },
@@ -175,15 +176,15 @@ ruleTester.run('lowercase-name with ignore=describe', rule, {
   valid: [
     {
       code: "describe('Foo', function () {})",
-      options: [{ ignore: ['describe'] }],
+      options: [{ ignore: [DescribeAlias.describe] }],
     },
     {
       code: 'describe("Foo", function () {})',
-      options: [{ ignore: ['describe'] }],
+      options: [{ ignore: [DescribeAlias.describe] }],
     },
     {
       code: 'describe(`Foo`, function () {})',
-      options: [{ ignore: ['describe'] }],
+      options: [{ ignore: [DescribeAlias.describe] }],
     },
   ],
   invalid: [],
@@ -193,15 +194,15 @@ ruleTester.run('lowercase-name with ignore=test', rule, {
   valid: [
     {
       code: "test('Foo', function () {})",
-      options: [{ ignore: ['test'] }],
+      options: [{ ignore: [TestCaseName.test] }],
     },
     {
       code: 'test("Foo", function () {})',
-      options: [{ ignore: ['test'] }],
+      options: [{ ignore: [TestCaseName.test] }],
     },
     {
       code: 'test(`Foo`, function () {})',
-      options: [{ ignore: ['test'] }],
+      options: [{ ignore: [TestCaseName.test] }],
     },
   ],
   invalid: [],
@@ -211,15 +212,15 @@ ruleTester.run('lowercase-name with ignore=it', rule, {
   valid: [
     {
       code: "it('Foo', function () {})",
-      options: [{ ignore: ['it'] }],
+      options: [{ ignore: [TestCaseName.it] }],
     },
     {
       code: 'it("Foo", function () {})',
-      options: [{ ignore: ['it'] }],
+      options: [{ ignore: [TestCaseName.it] }],
     },
     {
       code: 'it(`Foo`, function () {})',
-      options: [{ ignore: ['it'] }],
+      options: [{ ignore: [TestCaseName.it] }],
     },
   ],
   invalid: [],

src/rules/__tests__/no-commented-out-tests.test.js → src/rules/__tests__/no-commented-out-tests.test.ts

@@ -1,7 +1,7 @@
-import { RuleTester } from 'eslint';
+import { TSESLint } from '@typescript-eslint/experimental-utils';
 import rule from '../no-commented-out-tests';
 
-const ruleTester = new RuleTester({
+const ruleTester = new TSESLint.RuleTester({
   parserOptions: {
     sourceType: 'module',
   },
@@ -24,6 +24,7 @@ ruleTester.run('no-commented-out-tests', rule, {
     'testSomething()',
     '// latest(dates)',
     '// TODO: unify with Git implementation from Shipit (?)',
+    '#!/usr/bin/env node',
     [
       'import { pending } from "actions"',
       '',
@@ -141,8 +142,8 @@ ruleTester.run('no-commented-out-tests', rule, {
     {
       code: `
       foo()
-      /* 
-      describe("has title but no callback", () => {}) 
+      /*
+      describe("has title but no callback", () => {})
       */
       bar()`,
       errors: [{ messageId: 'commentedTests', column: 7, line: 3 }],