ts-migration/no-try-expect #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weird you had to change the parser. Empty catch should be allowed, I think (https://github.com/tc39/proposal-optional-catch-binding) |
SimenB
approved these changes
Jul 23, 2019
|
@SimenB Yeah, I figured it was b/c of something like that, but wanted to keep rolling through the bigger changes first :P Thanks for handling this one for me! |
|
🎉 This PR is included in version 22.13.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to alter the tests from using
catchw/o a parameter.For some reason it would cause a parsing error - I don't know if that's a TS or ESlint support problem, but since it's not critical to the rule (it just changes the
CatchClause#paramproperty fromIdentifiertonull), I've omitted it for now.