ts-migration/no-try-expect

src/rules/__tests__/no-try-expect.test.js → src/rules/__tests__/no-try-expect.test.ts

@@ -1,9 +1,9 @@
-import { RuleTester } from 'eslint';
+import { TSESLint } from '@typescript-eslint/experimental-utils';
 import rule from '../no-try-expect';
 
-const ruleTester = new RuleTester({
+const ruleTester = new TSESLint.RuleTester({
   parserOptions: {
-    ecmaVersion: 2019,
+    ecmaVersion: 9,
   },
 });
 
@@ -17,13 +17,13 @@ ruleTester.run('no-try-catch', rule, {
     });
     try {
 
-    } catch {
+    } catch(e) {
       expect('foo').toEqual('foo');
     }`,
     `it.skip('foo');
     try {
 
-    } catch {
+    } catch(e) {
       expect('foo').toEqual('foo');
     }`,
   ],

src/rules/no-try-expect.js → src/rules/no-try-expect.ts

@@ -1,10 +1,13 @@
-import { getDocsUrl, isTestCase } from './util';
+import { TSESTree } from '@typescript-eslint/experimental-utils';
+import { createRule, isTestCase } from './tsUtils';
 
-export default {
+export default createRule({
+  name: __filename,
   meta: {
     docs: {
       description: 'Prefer using toThrow for exception tests',
-      uri: getDocsUrl(__filename),
+      category: 'Best Practices',
+      recommended: false,
     },
     messages: {
       noTryExpect: [
@@ -13,13 +16,18 @@ export default {
         'or "await expect(yourFunction()).rejects.toThrow()" for async tests',
       ].join(' '),
     },
+    type: 'problem',
+    schema: [],
   },
+  defaultOptions: [],
   create(context) {
     let isTest = false;
     let catchDepth = 0;
 
-    function isThrowExpectCall(node) {
-      return catchDepth > 0 && node.callee.name === 'expect';
+    function isThrowExpectCall(node: TSESTree.CallExpression) {
+      return (
+        catchDepth > 0 && 'name' in node.callee && node.callee.name === 'expect'
+      );
     }
 
     return {
@@ -50,4 +58,4 @@ export default {
       },
     };
   },
-};
+});