Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): specify only majors for GH Actions #904

Merged
merged 5 commits into from Sep 21, 2021

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Sep 20, 2021

  • Set action versions to major
    This will create less PRs to update their versions
  • Set node version to 16

Taken from #903

.github/workflows/nodejs.yml Outdated Show resolved Hide resolved
@@ -18,9 +18,9 @@ jobs:
steps:
- uses: actions/checkout@v2

- uses: actions/setup-node@v2.4.0
- uses: actions/setup-node@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependabot is what changed from just specifying major: #620. But if renovate leaves it alone, I'm happy. I was unable to find any docs specifying the behavior - do you know?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- uses: actions/checkout@v2
is left alone, so let's assume this works 🙂

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@@ -18,6 +18,6 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Danger
uses: danger/danger-js@10.6.6
uses: danger/danger-js@v10
Copy link
Member

@SimenB SimenB Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orta it doesn't work to specify a range - is this something you could fix? 😀

https://github.com/jest-community/eslint-plugin-jest/runs/3663450145

@SimenB SimenB changed the title chore: update CI chore(ci): specify only majors for GH Actions Sep 21, 2021
@SimenB SimenB merged commit 7c23a69 into jest-community:main Sep 21, 2021
@MichaelDeBoey MichaelDeBoey deleted the patch-1 branch September 21, 2021 14:05
@github-actions
Copy link

🎉 This PR is included in version 24.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 25.0.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants