Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): specify only majors for GH Actions #904

Merged
merged 5 commits into from
Sep 21, 2021
Merged

chore(ci): specify only majors for GH Actions #904

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c1d48b2
chore: update CI
MichaelDeBoey Sep 20, 2021
e3e9323
chore: keep using node LTS
SimenB Sep 21, 2021
da21544
chore: use major of danger and codecov actions as well
SimenB Sep 21, 2021
2f89c2d
chore: add missing v (maybe?)
SimenB Sep 21, 2021
d5f4596
chore: danger needs specific version
SimenB Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 10 additions & 8 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
steps:
- uses: actions/checkout@v2

- uses: actions/setup-node@v2.4.0
- uses: actions/setup-node@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependabot is what changed from just specifying major: #620. But if renovate leaves it alone, I'm happy. I was unable to find any docs specifying the behavior - do you know?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint-plugin-jest/.github/workflows/nodejs.yml

Line 19 in aa249a2

- uses: actions/checkout@v2
is left alone, so let's assume this works 🙂

with:
node-version: 14.x
cache: yarn
Expand All @@ -36,7 +36,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2.4.0
- uses: actions/setup-node@v2
with:
node-version: 14.x
cache: yarn
Expand All @@ -50,7 +50,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2.4.0
- uses: actions/setup-node@v2
with:
node-version: 14.x
cache: yarn
Expand All @@ -74,7 +74,7 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2.4.0
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}
cache: yarn
Expand All @@ -87,7 +87,7 @@ jobs:
run: yarn test --coverage ${{ matrix.eslint-version >= 6 }}
env:
CI: true
- uses: codecov/codecov-action@v2.1.0
- uses: codecov/codecov-action@v2
if: ${{ matrix.eslint-version >= 6 }}
test-os:
name: Test on ${{ matrix.os }} using Node.js LTS
Expand All @@ -100,7 +100,7 @@ jobs:

steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2.4.0
- uses: actions/setup-node@v2
with:
node-version: 14.x
cache: yarn
Expand All @@ -110,14 +110,16 @@ jobs:
run: yarn test --coverage
env:
CI: true
- uses: codecov/codecov-action@v2
if: ${{ matrix.eslint-version >= 6 }}

docs:
if: ${{ github.event_name == 'pull_request' }}
needs: prepare-yarn-cache
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2.4.0
- uses: actions/setup-node@v2
with:
node-version: 14.x
cache: yarn
Expand All @@ -140,7 +142,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2.4.0
- uses: actions/setup-node@v2
with:
node-version: 14.x
cache: yarn
Expand Down