chore: make changedFiles option optional in shouldInstrument
#9197
Conversation
…shouldInstrument`
| @@ -58,7 +58,7 @@ export default function shouldInstrument( | |||
| if ( | |||
| // still cover if `only` is specified | |||
| !options.collectCoverageOnlyFrom && | |||
| options.collectCoverageFrom && | |||
| options.collectCoverageFrom.length && | |||
There was a problem hiding this comment.
sorta breaking? Only for people calling this manually though, and they'd get a type error. Fine for Jest 25.
Also a bug fix if you forgot to send it in
There was a problem hiding this comment.
well, Jest didn't always pass it, so that's nice :P Looking forward to making normalize in jest-config actually be type safe...
SimenB
force-pushed
the
should-instrument-type-tweak
branch
from
5f9e417
to
6e7347e
Compare
Codecov Report
@@ Coverage Diff @@
## master #9197 +/- ##
==========================================
+ Coverage 64.83% 64.85% +0.01%
==========================================
Files 279 279
Lines 11742 11744 +2
Branches 2887 2888 +1
==========================================
+ Hits 7613 7616 +3
+ Misses 3511 3510 -1
Partials 618 618
Continue to review full report at Codecov.
|
SimenB
changed the title
|undefined in shouldInstrumentshouldInstrument
* master: chore: upgrade to fsevents 2 (jestjs#9215) docs: remove expect.assertions(1) in rejects example of Tutoria… (jestjs#9149) chore: bump to istanbul alphas (jestjs#9192) Fix typo in JestPlatform.md (jestjs#9212) jest-snapshot: Ignore indentation for most serialized objects (jestjs#9203) fix(jest-types): tighten Config types and set more defaults (jestjs#9200) jest-snapshot: Improve colors when snapshots are updatable (jestjs#9132) jest-snapshot: Omit irrelevant received properties when property matchers fail (jestjs#9198) chore: make changedFiles option optional in `shouldInstrument` (jestjs#9197) fix(pretty-format): correctly detect memo (jestjs#9196) chore: regenerate lockfiles in e2e tests (jestjs#9193) chore: bump handlebars
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Extracted from #9192
Test plan
Green CI