feat: enable all babel syntax plugins #9774
Conversation
SimenB
changed the title
SimenB
force-pushed
the
node-syntax-preset
branch
from
c283c4a
to
2b47385
Compare
packages/babel-preset-jest/index.js
Outdated
| @@ -8,7 +8,6 @@ | |||
| module.exports = () => ({ | |||
| plugins: [ | |||
| require.resolve('babel-plugin-jest-hoist'), | |||
| require.resolve('@babel/plugin-syntax-object-rest-spread'), | |||
| require.resolve('@babel/plugin-syntax-bigint'), | |||
| require.resolve('babel-preset-current-node-syntax'), | |||
There was a problem hiding this comment.
we could add the 3 the new preset adds manually, then replace all the plugins we add with this new preset in 26. We already add bigint and object spread anyways, so there's precedence
|
This doesn't work on Node 8, which is fine - we will only land in Jest 26 anyways, which will drop node 8. However
|
|
Oh I can add Node 8 support (Babel still supports Node 8 anyway). |
|
No need to on our account unless the next version of babel will support node 8 🙂 I opened up nicolo-ribaudo/babel-preset-current-node-syntax#1 as well for the other error |
…pshots * upstream/master: (225 commits) docs: add CLA link to contributing docs (jestjs#9789) chore: roll new version of docs v25.3.0 chore: update changelog for release chore(jest-types): correct type testRegex for ProjectConfig (jestjs#9780) feat(circus): enable writing async test event handlers (jestjs#9397) feat: enable all babel syntax plugins (jestjs#9774) chore: add helper for getting Jest's config in e2e tests (jestjs#9770) feat: pass ESM options to transformers (jestjs#9597) chore: replace `any`s with `unknown`s (jestjs#9626) feat: pass ESM options to Babel (jestjs#9766) chore(website): add copy button the code blocks (jestjs#9750) chore: bump istanbul-reports for new uncovered lines design (jestjs#9758) chore: correct CHANGELOG.md (jestjs#9763) chore(jest-types): expose type `CacheKeyOptions` for `getCacheK… (jestjs#9762) docs: Fix simple typo, seperated -> separated (jestjs#9760) v25.2.7 chore: update changelog for release fix: drop getters and setters when diffing objects for error (jestjs#9757) chore(jest-types): correct return type of shouldRunTestSuite fo… (jestjs#9753) ...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Breaking due to the increased peer dep, so let's land this in Jets 26.Also needs nicolo-ribaudo/babel-preset-current-node-syntax@565b63a to be publishedAdds any babel syntax syntax plugins needed for the current runtime that exists in some version of node. Makes it so user don't have to care about the Babel implementation detail.
Ref
Test plan
Not sure... It looks correct? 😀