Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump slf4j to 2.0.0-alpha6 #7555

Merged
merged 1 commit into from Feb 9, 2022

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Feb 9, 2022

SLF4J 2.0.x series requires Java 8. It builds upon the 1.8.x series and adds a backward-compatible fluent logging api. By backward-compatible, we mean that existing logging frameworks do not have to be changed for the user to benefit from the fluent logging API. However, existing frameworks must migrate to the ServiceLoader mechanism. The resulting internal changes are detailed in the FAQ page.

  • SLF4J now ships with the slf4j-reload4j module delegating to the reload4j backend. Reload4j is a drop-in replacement for log4j version 1.2.17.
  • SimpleLogger now prints the thread Id if instructed to do so. This fixes SLF4J-499 requested by Michael Osipov

Signed-off-by: Jochen Schalanda jochen@schalanda.name

> SLF4J 2.0.x series requires Java 8. It builds upon the 1.8.x series and adds a backward-compatible fluent logging api. By backward-compatible, we mean that existing logging frameworks do not have to be changed for the user to benefit from the [fluent logging API](https://www.slf4j.org/manual.html#fluent). However, existing frameworks must migrate to the `ServiceLoader` mechanism. The resulting internal changes are [detailed](https://www.slf4j.org/faq.html#changesInVersion200) in the FAQ page.
>
> - SLF4J now ships with the slf4j-reload4j module delegating to the reload4j backend. Reload4j is a drop-in replacement for log4j version 1.2.17.
> - `SimpleLogger` now prints the thread Id if instructed to do so. This fixes [SLF4J-499](https://jira.qos.ch/browse/SLF4J-499) requested by Michael Osipov

Signed-off-by: Jochen Schalanda <jochen@schalanda.name>
@olamy olamy added the dependencies Pull requests that update a dependency file label Feb 9, 2022
@sbordet
Copy link
Contributor

sbordet commented Feb 9, 2022

@joschi thanks for the PR. We are currently have SLF4J APIs at 2.0.0-alpha5, and we rely on dependabot to bump our dependencies.
Is there some special reason you wanted Jetty to update SLF4J from 2.0.0-alpha5 to 2.0.0-alpha6?

@joakime joakime self-assigned this Feb 9, 2022
@joakime joakime added this to the 10.0.x milestone Feb 9, 2022
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm going to merge this.

@joakime joakime merged commit 9073fe2 into jetty:jetty-10.0.x Feb 9, 2022
@joschi
Copy link
Contributor Author

joschi commented Feb 9, 2022

@joschi thanks for the PR. We are currently have SLF4J APIs at 2.0.0-alpha5, and we rely on dependabot to bump our dependencies.
Is there some special reason you wanted Jetty to update SLF4J from 2.0.0-alpha5 to 2.0.0-alpha6?

@sbordet Good question, thanks for getting back to this!

I thought this was the version used in Logback 1.3.0-alpha13, but in fact it is still referencing SLF4J 2.0.0-alpha5.
https://github.com/qos-ch/logback/blob/34332a0c12751dec101cb6e1724d3930cfaab7e6/pom.xml#L65

My intention was getting dependencies aligned, but it looks I was wrong there.
The motivation was this: dropwizard/metrics#2418

@joakime
Copy link
Contributor

joakime commented Feb 9, 2022

FYI, Part of our validation of staged (potential) Jetty releases is to get a clean build+test out of dropwizard-metrics.

https://jenkins.webtide.net/job/external_oss/job/dropwizard-metrics-build/25/
This was the first time we ever got all 3 new Jetty versions building against an open source project at the same time in the same build.

@joschi joschi deleted the slf4j-2.0.0-alpha6-jetty-10 branch February 9, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants