Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an open function #310

Merged
merged 1 commit into from Mar 6, 2024
Merged

feat: add an open function #310

merged 1 commit into from Mar 6, 2024

Conversation

JorickPepin
Copy link
Member

An open task has recently been added to Docker Starter. However, it works only on macOS as the Linux command is xdg-open. Having it here allows using the right command according to the operating system thanks to the OSHelper. WDYT?

src/functions.php Outdated Show resolved Hide resolved
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 except a little comment

src/functions.php Outdated Show resolved Hide resolved
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@lyrixx lyrixx merged commit e4a241b into main Mar 6, 2024
8 checks passed
@lyrixx lyrixx deleted the feat_open branch March 6, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants