Implement more robust isTTY check

[kibertoad]

As per pinojs/pino-pretty#220 (comment)

[kibertoad]

@jorgebucaran What's up with GitHub actions? I see there is a CI flow defined, but it doesn't seem to be running.

[mcollina]

I can confirm this fixes the compatibility problems we have for pino transport

[jorgebucaran]

Wow, thanks! So, is this Node's canonical way to detect if you are in a pipe? Other than not being available inside worker_threads, are there any disadvantages to process.stdout.isTTY? Curious.

[jorgebucaran]

@jorgebucaran What's up with GitHub actions? I see there is a CI flow defined, but it doesn't seem to be running.

It was configured to run against push only. It's fixed now. 🙆‍♂️

[kibertoad]

@jorgebucaran This discussion might be useful: nodejs/node#28386

[mcollina]

@jorgebucaran is there an ETA for a release that would ship this?

[jorgebucaran]

Colorette is an ES module, so this should be changed to use import.

[kibertoad]

will that be compatible with current dual publishing of CJS and ES versions? do you autoreplace?

[jorgebucaran]

Nope, looks like the time to upgrade that script has finally come! I can take care of that after we merge this.

[kibertoad]

done

[jorgebucaran]

Thanks! I'll merge here, update the script and publish a new minor version shortly.

[jorgebucaran]

Released as 1.4.0.

[jorgebucaran]

@mcollina @kibertoad Is there any reason to check if tty is defined before using tty.isatty()? Should be defined, no?

import * as tty from "tty"
 ...
const isCompatibleTerminal =
  tty && tty.isatty(1) && env.TERM && env.TERM !== "dumb"

[kibertoad]

@jorgebucaran It's a node-specific thing. There were prior bug reports from people using colorette outside of Node, I wanted to safeguard against that from the get go.

[jorgebucaran]

Gotcha, thanks. I still feel that this should be handled by the user's bundler / preprocessor (#64 (comment)).