Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement more robust isTTY check #63

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Implement more robust isTTY check #63

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f3040f
More robust isTTY check
kibertoad Sep 4, 2021
779f4ba
Replace require with import
kibertoad Sep 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
const tty = require('tty');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colorette is an ES module, so this should be changed to use import.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will that be compatible with current dual publishing of CJS and ES versions? do you autoreplace?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, looks like the time to upgrade that script has finally come! I can take care of that after we merge this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

const env = process.env;

const isDisabled = "NO_COLOR" in env
const isForced = "FORCE_COLOR" in env
const isWindows = process.platform === "win32"

const isCompatibleTerminal =
process.stdout != null &&
process.stdout.isTTY &&
tty &&
tty.isatty(1) &&
env.TERM &&
env.TERM !== "dumb"

Expand Down