Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status of createSymlink and createSymlinkSync #758

Closed
davidjgoss opened this issue Feb 8, 2020 · 1 comment · Fixed by #766
Closed

status of createSymlink and createSymlinkSync #758

davidjgoss opened this issue Feb 8, 2020 · 1 comment · Fixed by #766
Milestone

Comments

@davidjgoss
Copy link

davidjgoss commented Feb 8, 2020

These methods are exposed on the main export of fs-extra:

  • createSymlink
  • createSymlinkSync

But they aren't documented (and, I assume consequently, they aren't in the community-published typings).

Should these be added to the documentation? Or is the intent for users to just use ensureSymlink - and if so should these be omitted from the main export?

@RyanZim
Copy link
Collaborator

RyanZim commented Feb 8, 2020

Yeah, that's a mistake that they weren't documented. However, I'm considering removing the create* aliases in the next major release.

@RyanZim RyanZim added this to the 9.0.0 milestone Feb 8, 2020
peterblazejewicz added a commit to peterblazejewicz/DefinitelyTyped that referenced this issue Feb 15, 2020
Missed:
- `createSymlink`
- `createSymlinkSync`

see: jprichardson/node-fs-extra#758
see: cucumber/cucumber-js#1286

Thanks!
PranavSenthilnathan pushed a commit to DefinitelyTyped/DefinitelyTyped that referenced this issue Feb 18, 2020
Missed:
- `createSymlink`
- `createSymlinkSync`

see: jprichardson/node-fs-extra#758
see: cucumber/cucumber-js#1286

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants