Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add noImplicitAny and noImplicitReturns, fix compilation #1286

Merged
merged 33 commits into from Mar 7, 2020
Merged

build: add noImplicitAny and noImplicitReturns, fix compilation #1286

merged 33 commits into from Mar 7, 2020

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Feb 3, 2020 •
edited

Part of #1269

noImplicitReturns ended up being no changes. noImplicitAny on the other hand needed quite a lot.

  • Figure out why fs-extra typings don't line up with code
  • Figure out why unit-test fails on not picking up our external module declarations

charlierudolph
charlierudolph reviewed Feb 6, 2020
View reviewed changes
Copy link
Member

@charlierudolph charlierudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on. Was definitely the biggest task

features/step_definitions/file_steps.ts Outdated Show resolved Hide resolved
features/support/hooks.ts Outdated Show resolved Hide resolved
src/cli/i18n.ts Show resolved Hide resolved
src/formatter/json_formatter.ts Show resolved Hide resolved
@davidjgoss davidjgoss marked this pull request as ready for review February 8, 2020 12:11
@davidjgoss davidjgoss mentioned this pull request Feb 8, 2020
Merged
peterblazejewicz added a commit to peterblazejewicz/DefinitelyTyped that referenced this pull request Feb 15, 2020
@peterblazejewicz
fix(fs-extra): missing createSymlink
b1d624e 
Missed:
- `createSymlink`
- `createSymlinkSync`

see: jprichardson/node-fs-extra#758
see: cucumber/cucumber-js#1286

Thanks!
@peterblazejewicz peterblazejewicz mentioned this pull request Feb 15, 2020
Merged
6 tasks
PranavSenthilnathan pushed a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request Feb 18, 2020
@peterblazejewicz
fix(fs-extra): missing createSymlink (#42385)
6ab9d89 
Missed:
- `createSymlink`
- `createSymlinkSync`

see: jprichardson/node-fs-extra#758
see: cucumber/cucumber-js#1286

Thanks!
charlierudolph
charlierudolph reviewed Mar 4, 2020
View reviewed changes
Copy link
Member

@charlierudolph charlierudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for doing this! Sorry took a while to get to a review. Just a few small things.

features/step_definitions/fixture_steps.ts Show resolved Hide resolved
features/support/world.ts Outdated Show resolved Hide resolved
src/cli/i18n.ts Show resolved Hide resolved
src/formatter/get_color_fns.ts Show resolved Hide resolved
src/formatter/helpers/event_data_collector.ts Outdated Show resolved Hide resolved
src/runtime/pickle_runner_spec.ts Outdated Show resolved Hide resolved
src/support_code_library_builder/validate_arguments.ts Outdated Show resolved Hide resolved
src/support_code_library_builder/world.ts Outdated Show resolved Hide resolved
test/formatter_helpers.ts Outdated Show resolved Hide resolved
test/gherkin_helpers.ts Outdated Show resolved Hide resolved
@davidjgoss davidjgoss mentioned this pull request Mar 5, 2020
Merged
@davidjgoss
Copy link
Contributor Author

@charlierudolph all addressed

charlierudolph
charlierudolph approved these changes Mar 7, 2020
View reviewed changes
features/support/world.ts Outdated Show resolved Hide resolved
src/runtime/attachment_manager/index.ts Show resolved Hide resolved
@charlierudolph charlierudolph mentioned this pull request Mar 7, 2020
Closed
6 tasks
@davidjgoss davidjgoss merged commit cf676b8 into master Mar 7, 2020
@davidjgoss davidjgoss deleted the typescript/noImplicitReturns branch March 7, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlierudolph charlierudolph charlierudolph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidjgoss @charlierudolph