Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not check errors with instanceof. #805

Merged
merged 1 commit into from Jun 3, 2020
Merged

fix: do not check errors with instanceof. #805

merged 1 commit into from Jun 3, 2020

Conversation

federicobozzini
Copy link
Contributor

@federicobozzini federicobozzini commented Jun 3, 2020 •
edited by RyanZim

This fixes cross-VM type issues in Jest #804 .

See isaacs/rimraf@aa50e02

Fixes #804

@federicobozzini
fix: do not check errors with instanceof.
2f76ccf 
This fixes cross-VM type issues in Jest.

See isaacs/rimraf@aa50e02
JPeer264
JPeer264 approved these changes Jun 3, 2020
View reviewed changes
Copy link
Collaborator

@JPeer264 JPeer264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me as it got already approved and reviewed at rimraf

@RyanZim RyanZim merged commit f86c099 into jprichardson:master Jun 3, 2020
@RyanZim RyanZim mentioned this pull request Jun 3, 2020
Closed
@RyanZim
Copy link
Collaborator

RyanZim commented Jun 4, 2020

Published in 9.0.1 🎉

@federicobozzini federicobozzini deleted the patch-1 branch June 4, 2020 06:30
@develar develar mentioned this pull request Mar 14, 2021
Closed
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPeer264 JPeer264 JPeer264 approved these changes

@manidlou manidlou manidlou approved these changes

@RyanZim RyanZim RyanZim approved these changes

@jprichardson jprichardson Awaiting requested review from jprichardson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using jest there seems to be a problem when deleting a file or a folder on Windows
4 participants
@federicobozzini @RyanZim @JPeer264 @manidlou