New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Check range when set module scope member #1899
Open
ZhiruiLi
wants to merge
123
commits into
jsdoc:main
Choose a base branch
from
ZhiruiLi:fix-for-module-range
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Record module range when saving current module, and check if doclet in range when call `setModuleScopeMemberOf` function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record module range when saving current module, and check if doclet in
range when call
setModuleScopeMemberOf
function.When walking through AST, vistor will treat the enum as module, which will cause wrong full name for the next element.
For example:
After visit
MyEnum
, thecurrentModule
will becomemodule:MyEnum
, and the longname ofIMyMessage2
will becomemodule:MyEnum~IMyMessage2
even if it does not belong toMyEnum
.Here, we need to check if current element is out of current module, if it is, the branch should not be executed.