Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check range when set module scope member #1899

Open
wants to merge 123 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
Show all changes
123 commits
Select commit Hold shift + click to select a range
c90dffe
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 4, 2021
3fcd0af
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 4, 2021
1ee4a34
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 4, 2021
c9288ba
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 4, 2021
1d58527
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 5, 2021
b494b7c
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 5, 2021
6db2ea4
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 5, 2021
4566a95
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 5, 2021
858feaf
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 5, 2021
e8e6320
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 5, 2021
a0a51f3
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 5, 2021
09b091c
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 6, 2021
738300d
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 6, 2021
b237055
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 6, 2021
977c527
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 6, 2021
7c047d4
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 6, 2021
0d61a21
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 6, 2021
0ea2937
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 7, 2021
4b260ff
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 7, 2021
2d3697a
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 7, 2021
59a66ef
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 7, 2021
2beac2b
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 7, 2021
0cf139d
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 8, 2021
d18ccb9
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 8, 2021
f7003b8
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 8, 2021
e30a557
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 8, 2021
56fb0a0
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 8, 2021
a613d25
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 8, 2021
58b15ab
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 8, 2021
48d31f3
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 9, 2021
29a1ea8
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 9, 2021
6448c69
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 9, 2021
41b4c21
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 9, 2021
53a2e96
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 9, 2021
3187b4c
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 10, 2021
141d498
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 10, 2021
64c0dc5
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 10, 2021
d9f8de2
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 10, 2021
b2e597d
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 10, 2021
b6d9471
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 10, 2021
f0881f4
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 11, 2021
d077806
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 11, 2021
32b07a7
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 11, 2021
4ec743f
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 11, 2021
819ae76
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 11, 2021
b5365e2
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 12, 2021
bba5cd4
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 12, 2021
a9f7f9f
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 12, 2021
e6b0fd6
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 13, 2021
c300770
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 13, 2021
88b8445
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 13, 2021
1e86001
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 13, 2021
53d2bec
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 13, 2021
5d7f7f9
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 14, 2021
0a67a73
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 14, 2021
e772284
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 14, 2021
a5b7bd2
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 14, 2021
ff527d6
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 14, 2021
2015dfc
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 14, 2021
aa31bf4
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 14, 2021
719feca
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 15, 2021
135516e
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 15, 2021
e351b77
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 15, 2021
90375f6
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 15, 2021
f893427
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 16, 2021
27b00f6
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 16, 2021
189cb64
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 16, 2021
4d299de
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 16, 2021
b30ba56
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 16, 2021
a9977a9
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 17, 2021
8d23ad0
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 17, 2021
0d426a1
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 17, 2021
00fd216
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 17, 2021
56a14f5
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 17, 2021
01953d2
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 17, 2021
ec2e5f8
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 18, 2021
62d0763
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 18, 2021
2b14d9c
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 18, 2021
0110657
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 18, 2021
7f58309
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 18, 2021
11d13d4
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 18, 2021
7b74336
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 19, 2021
1c26054
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 19, 2021
870df58
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 19, 2021
24e0aad
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 19, 2021
0adb6b8
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 19, 2021
cec65df
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 19, 2021
437020b
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 20, 2021
1631455
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 20, 2021
dc082c4
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 20, 2021
99e3bfd
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 20, 2021
377d03b
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 20, 2021
b82e680
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 20, 2021
09b171d
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 20, 2021
42514a6
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 21, 2021
f2bafe1
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 21, 2021
eee7558
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 21, 2021
375898b
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 21, 2021
acb186c
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 21, 2021
10ab2aa
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 21, 2021
f73b68e
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 21, 2021
922f8db
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 22, 2021
e88d97a
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 22, 2021
34bc920
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 22, 2021
0c07019
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 22, 2021
9c95cd3
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 22, 2021
cafd2a0
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 23, 2021
e8954b3
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 23, 2021
d3f43c7
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 23, 2021
615e709
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 23, 2021
d486af3
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 23, 2021
4210985
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 24, 2021
2140e79
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 24, 2021
971eff9
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 24, 2021
ebbfc02
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 24, 2021
0af48ce
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 24, 2021
1779b4f
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 25, 2021
670d64d
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 25, 2021
4b36abc
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 25, 2021
a043aa4
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 25, 2021
621406d
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 25, 2021
6380851
chore(deps): update dependency yargs-parser to 5.0.0-security.0 [secu…
renovate-bot Mar 26, 2021
6784355
fix: Check range when set module scope member
Mar 26, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/jsdoc/lib/jsdoc/src/handlers.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@ class CurrentModule {
this.doclet = doclet;
this.longname = doclet.longname;
this.originalName = doclet.meta.code.name || '';
this.range = doclet.meta.range || [0, Number.MAX_SAFE_INTEGER];
}
}

function filterByLongname({longname}) {
// you can't document prototypes
if ( /#$/.test(longname) ) {
Expand Down Expand Up @@ -80,12 +82,19 @@ function setCurrentModule(doclet) {
}
}

function isInModule(doclet) {
return currentModule && currentModule.longname !== doclet.name &&
doclet.meta && doclet.meta.range &&
currentModule.range[0] <= doclet.meta.range[0] &&
currentModule.range[1] >= doclet.meta.range[1];
}

function setModuleScopeMemberOf(parser, doclet) {
let parentDoclet;
let skipMemberof;

// handle module symbols that are _not_ assigned to module.exports
if (currentModule && currentModule.longname !== doclet.name) {
if (isInModule(doclet)) {
if (!doclet.scope) {
// is this a method definition? if so, we usually get the scope from the node directly
if (doclet.meta && doclet.meta.code && doclet.meta.code.node &&
Expand Down