Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dispatching click event executes click handler for disabled elements #2665

Closed
eps1lon opened this issue Sep 17, 2019 · 1 comment
Closed

dispatching click event executes click handler for disabled elements #2665

eps1lon opened this issue Sep 17, 2019 · 1 comment

Comments

@eps1lon
Copy link
Contributor

eps1lon commented Sep 17, 2019

Basic info:

  • Node.js version: 10.16.3
  • jsdom version: 15.1.1

Minimal reproduction case

const { JSDOM } = require("jsdom");

const { window } = new JSDOM(`
<!DOCTYPE html>
<html>
  <body><button disabled></button></body>
</html>
`);

const button = window.document.querySelector('button');
button.addEventListener('click', () => console.log('click'));

button.click();
button.dispatchEvent(new window.MouseEvent('click'))

https://runkit.com/eps1lon/5d80dae1e7cc46001351ca95

How does similar code behave in browsers?

https://jsbin.com/kebukirute/edit?html,js,console

In the browser no click handler is called. In JSDOM the click handler is called on dispatchEvent but not click().
This was referenced Sep 17, 2019
Closed
Merged
brendo added a commit to brendo/jsdom that referenced this issue Oct 9, 2019
@brendo
dispatchEvent now takes into account if an element has been disabled. F…
6922582 
…ixes jsdom#2665
@brendo brendo mentioned this issue Oct 9, 2019
Closed
@domenic
Copy link
Member

domenic commented Oct 14, 2019

jsdom matches the spec and Firefox here. Blink and WebKit do not match the spec.

The interop issue here is tracked in whatwg/html#2368, which may eventually lead to either fixing Blink and WebKit, or updating the spec to match them and then changing Firefox and jsdom. Until that gets done though, jsdom is behaving as intended, so I'll close this.

@domenic domenic closed this as completed Oct 14, 2019
@domenic domenic mentioned this issue Oct 14, 2019
Open
@yanick yanick mentioned this issue Mar 31, 2022
Closed
@ChristopherChudzicki ChristopherChudzicki mentioned this issue Aug 2, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dispatchEvent now takes into account if an element has been disabled brendo/jsdom
2 participants
@domenic @eps1lon