Use css-color module #3674
Closed
Use css-color module #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# dom/get-computed-style/getComputedStyle # jsdom x 24,796 ops/sec ±2.27% (92 runs sampled)
# dom/get-computed-style/getComputedStyle # jsdom x 13,315 ops/sec ±2.00% (88 runs sampled)
# dom/get-computed-style/getComputedStyle # jsdom x 8,834 ops/sec ±4.68% (88 runs sampled)
Otherwise, if a new syntax such as 'rgb(128 128 128 / 0.5)' is passed, the value will be returned as is.
asamuzaK
changed the title
|
The commit log is a mess, so I'll close it and submit a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3657
Benchmark result
The last
getComputedStyle() on element with non-rgb colorbenchmark is simply failing, so ignore it.It looks like jsdom does not pass non-rgb colors e.g.
color-mix()correctly togetSpecifiedColor().We need to fix https://github.com/jsdom/jsdom/blob/main/lib/jsdom/living/helpers/style-rules.js#L175 to support them.