Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use css-color module #3674

Closed
wants to merge 12 commits into from
Closed

Use css-color module #3674

wants to merge 12 commits into from

Commits on Jan 26, 2024

  1. Add benchmark 

    # dom/get-computed-style/getComputedStyle #
jsdom  x 24,796 ops/sec ±2.27% (92 runs sampled)
    @asamuzaK
    asamuzaK committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    9e77b18 View commit details
    Browse the repository at this point in the history

  2. Install css-color

    @asamuzaK
    asamuzaK committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    feefd9c View commit details
    Browse the repository at this point in the history

  3. Use css-color only if color is neither hex / rgb 

    # dom/get-computed-style/getComputedStyle #
jsdom  x 13,315 ops/sec ±2.00% (88 runs sampled)
    @asamuzaK
    asamuzaK committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    debce3c View commit details
    Browse the repository at this point in the history

  4. Always use css-color 

    # dom/get-computed-style/getComputedStyle #
jsdom  x 8,834 ops/sec ±4.68% (88 runs sampled)
    @asamuzaK
    asamuzaK committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    3266aee View commit details
    Browse the repository at this point in the history

  5. Revert

    @asamuzaK
    asamuzaK committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    47fdaef View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. Fix lint issues

    @asamuzaK
    asamuzaK committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    7e609e5 View commit details
    Browse the repository at this point in the history

  2. Update css-color

    @asamuzaK
    asamuzaK committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    2c6f2bd View commit details
    Browse the repository at this point in the history

  3. Make sure comma exists 

    Otherwise, if a new syntax such as 'rgb(128 128 128 / 0.5)' is passed, the value will be returned as is.
    @asamuzaK
    asamuzaK committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    a7bbf06 View commit details
    Browse the repository at this point in the history

  4. Update get-computed-style.js

    @asamuzaK
    asamuzaK committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    2154a65 View commit details
    Browse the repository at this point in the history

  5. Update colors.js

    @asamuzaK
    asamuzaK committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    fe2cc13 View commit details
    Browse the repository at this point in the history

  6. Update colors.js

    @asamuzaK
    asamuzaK committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    b65cc8f View commit details
    Browse the repository at this point in the history

  7. Update get-computed-style.js

    @asamuzaK
    asamuzaK committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    b65cde0 View commit details
    Browse the repository at this point in the history