Allow title attribute or aria-label attribute instead of accessible child in the "anchor-has-content" rule

[gorohash]

Fixes #423

Allowed title and aria-label attributes instead of text content in the "anchor-has-content" rule.

[jessebeach]

@gorohash are you thinking that using both title and aria-label provides visual and non-visual label access?

[gorohash]

@jessebeach
I think it provides non-visual label access, but it doesn't necessarily provide enough visual label access.
However, as discussed in #423, icons can provide the meaning visually.

[backwardok]

@gorohash Requiring both title and aria-label seems like you're trying to use the title as a hover tooltip for visual affordance, but I don't think that's always necessary. I would update this to allow for passing for having a title or aria-label but not forcing them both to be present.

[gorohash]

@backwardok I agree with you. A tooltip shown by title is not always the best way to provide visual affordance. I look forward to your update!

[backwardok]

Hi @gorohash ! I may have been confusing with my language. I meant I recommend that it be updated to be an OR instead of an AND 🙂 Would you want to make that update to your own code?

[gorohash]

@backwardok Thanks for your advice! I updated my code

[backwardok]

Thanks for adding in this support!

[codecov]

Codecov Report

Merging #727 (e6bfd5c) into main (7b3492b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #727   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files         104      104           
  Lines        1555     1557    +2     
  Branches      523      524    +1     
=======================================
+ Hits         1544     1546    +2     
  Misses         11       11           

Files Changed	Coverage Δ
src/rules/anchor-has-content.js	100.00% <100.00%> (ø)

[backwardok]

Hey @jessebeach ! Was wondering if you could review this PR? Thanks! 😄

[ljharb]

@jessebeach this is freshly rebased; mind giving it a review?

[jessebeach]

I'll have a look tonight after the kiddo goes to sleep.

[jessebeach]

This is a good improvement.

In the future, we will want to incorporate the mayHaveAccessibleLabel utility and somehow port a consideration for title back into that utility, so that we don't have so much logic directly in a rule, where it might diverge from other similar rules.

But for now, this is an improvement to this rule.

[jessebeach]

Thank you @backwardok !!

[jessebeach]

ack, apologies @ljharb! I hit the Merge button on this one. I know you like to merge the commits in a different way.

[ljharb]

No worries, it’s fine :-) thanks for reviewing!