[Fix] jsx-one-expression-per-line: fix when using tabs

Fixes #2152.
jsx-eslint · Mar 13, 2019 · 2c091dd · 2c091dd
1 parent d3dc4c8
commit 2c091dd
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 2 deletions.
diff --git a/lib/rules/jsx-one-expression-per-line.js b/lib/rules/jsx-one-expression-per-line.js
@@ -94,8 +94,8 @@ module.exports = {
             return;
           }
 
-          countNewLinesBeforeContent = (child.raw.match(/^ *\n/g) || []).length;
-          countNewLinesAfterContent = (child.raw.match(/\n *$/g) || []).length;
+          countNewLinesBeforeContent = (child.raw.match(/^\s*\n/g) || []).length;
+          countNewLinesAfterContent = (child.raw.match(/\n\s*$/g) || []).length;
         }
 
         const startLine = child.loc.start.line + countNewLinesBeforeContent;

diff --git a/tests/lib/rules/jsx-one-expression-per-line.js b/tests/lib/rules/jsx-one-expression-per-line.js
@@ -28,6 +28,42 @@ const ruleTester = new RuleTester({parserOptions});
 ruleTester.run('jsx-one-expression-per-line', rule, {
   valid: [{
     code: '<App />'
+  }, {
+    code: `
+\t\t<AllTabs>
+\t\t\tFail
+\t\t</AllTabs>
+    `
+  }, {
+    code: `
+\t\t<TagsWithTabs>
+      Fail
+\t\t</TagsWithTabs>
+    `
+  }, {
+    code: `
+    <ClosedTagWithTabs>
+      Fail
+\t\t</ClosedTagWithTabs>
+    `
+  }, {
+    code: `
+\t\t<OpenTagWithTabs>
+      OK
+    </OpenTagWithTabs>
+    `
+  }, {
+    code: `
+    <TextWithTabs>
+\t\t\tOK
+    </TextWithTabs>
+    `
+  }, {
+    code: `
+    <AllSpaces>
+      OK
+    </AllSpaces>
+    `
   }, {
     code: '<App></App>'
   }, {