[Fix] no-this-in-sfc: Fix false positive on SFC defined as object p…

…roperty Fixes #2147
jsx-eslint · Mar 5, 2019 · 6835d8b · 6835d8b
1 parent e1a5889
commit 6835d8b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/rules/no-this-in-sfc.js b/lib/rules/no-this-in-sfc.js
@@ -31,7 +31,7 @@ module.exports = {
     MemberExpression(node) {
       if (node.object.type === 'ThisExpression') {
         const component = components.get(utils.getParentStatelessComponent());
-        if (!component) {
+        if (!component || component.node && component.node.parent && component.node.parent.type === 'Property') {
           return;
         }
         context.report({

diff --git a/tests/lib/rules/no-this-in-sfc.js b/tests/lib/rules/no-this-in-sfc.js
@@ -137,6 +137,17 @@ ruleTester.run('no-this-in-sfc', rule, {
       };
     }`,
     parser: 'babel-eslint'
+  }, {
+    code: `
+    export const Example = ({ prop }) => {
+      return {
+        handleClick: () => {},
+        renderNode() {
+          return <div onClick={this.handleClick} />;
+        },
+      };
+    };`,
+    parser: 'babel-eslint'
   }],
   invalid: [{
     code: `