Verify function expression

jsx-eslint · May 8, 2019 · c4dd9d0 · c4dd9d0
1 parent 4012bee
commit c4dd9d0
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 1 deletion.
diff --git a/lib/rules/no-unused-class-component-methods.js b/lib/rules/no-unused-class-component-methods.js
@@ -58,7 +58,12 @@ module.exports = {
         node.type === 'ClassProperty' &&
         node.value.type === 'ArrowFunctionExpression'
       );
-      return isMethod || isArrowFunction;
+      const isFunctionExpression = (
+        node.type === 'ClassProperty' &&
+        node.value.type === 'FunctionExpression'
+      );
+
+      return isMethod || isArrowFunction || isFunctionExpression;
     };
     const checkMethods = node => {
       const properties = astUtil.getComponentProperties(node);

diff --git a/tests/lib/rules/no-unused-class-component-methods.js b/tests/lib/rules/no-unused-class-component-methods.js
@@ -228,6 +228,19 @@ ruleTester.run('no-unused-class-component-methods', rule, {
         }
       `,
       parser: 'babel-eslint'
+    },
+    {
+      code: `
+        class Foo extends React.Component {
+          action = function() {
+            console.log('error');
+          }
+          render() {
+            return <button onClick={() => this.action()}>Click</button>;
+          }
+        }
+      `,
+      parser: 'babel-eslint'
     }
   ],
 
@@ -352,6 +365,24 @@ ruleTester.run('no-unused-class-component-methods', rule, {
         line: 3,
         column: 11
       }]
+    },
+    {
+      code: `
+        class Foo extends React.Component {
+          action = function() {
+            console.log('error');
+          }
+          render() {
+            return null;
+          }
+        }
+      `,
+      parser: 'babel-eslint',
+      errors: [{
+        message: 'Unused method "action" of class "Foo"',
+        line: 3,
+        column: 11
+      }]
     }
   ]
 });