Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] display-name: fix identifying _ as a capital letter #3335

Merged
merged 1 commit into from Jul 18, 2022

Conversation

apbarrero
Copy link
Contributor

Fix #3334

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #3335 (6b42731) into master (87fb344) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3335   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files         123      123           
  Lines        8788     8788           
  Branches     3190     3190           
=======================================
  Hits         8587     8587           
  Misses        201      201           
Impacted Files Coverage Δ
lib/util/isFirstLetterCapitalized.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87fb344...6b42731. Read the comment docs.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

False positive for react/display-name on function value assignment to identifier starting with _
2 participants