[Fix] no-unknown-property add properties onToggle, fill, as, pointer events, media events and touch events
#3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and pointer events
Codecov Report
@@ Coverage Diff @@
## master #3385 +/- ##
==========================================
+ Coverage 97.57% 97.58% +0.01%
==========================================
Files 123 123
Lines 8954 8957 +3
Branches 3268 3269 +1
==========================================
+ Hits 8737 8741 +4
+ Misses 217 216 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I made the suggestions you had ✔️ |
sjarva
changed the title
no-unknown-property add properties onToggle, fill, as and pointer events
|
My project started emitting eslint errors when using touch events. I don't see them events listed in this change. Could/should they also be included? https://reactjs.org/docs/events.html#touch-events
|
sjarva
changed the title
no-unknown-property add properties onToggle, fill, as and pointer eventsno-unknown-property add properties onToggle, fill, as, pointer events, media events and touch events
|
Thanks for pointing them out @jdufresne 👍 |
… iframes have `scrolling`; video has `playsInline`
ljharb
force-pushed
the
no-unknown-property-more-valid-properties
branch
from
d452ea7
to
a2ec87d
Compare
ljharb
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3384