Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to setup-gradle@v3 #803

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

TWiStErRob
Copy link
Contributor

@TWiStErRob TWiStErRob commented Jan 27, 2024

Proposed commit message:

Migrate from gradle-build-action to setup-gradle GitHub Action.

A new way of consuming Gradle Actions is coming in v3.
There are no significant changes to the action logic,
the v3 version and the new action is a drop-in replacement.

Setting up AND running Gradle in the same step is deprecated,
so the steps are split into two: setup-gradle + `run:`.

Because `run:` uses different shells on different OSs,
the `-Pa=b` Gradle params are moved to `ORG_GRADLE_PROJECT_a: b`
environment variables, because that approach is fully cross platform.

Removed `cache: 'gradle'` from setup-java,
because setup-gradle is doing the same, and more.

PR: #803

PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
  • Site documentation in .adoc file references demo in src/demo/java instead of containing code blocks as text
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Documentation (new extension)

  • The docs/docs-nav.yml navigation has an entry for the new extension
  • The package-info.java contains information about the new extension

Code (general)

  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks
  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)

Code (new package)

  • The new package is exported in module-info.java
  • The new package is also present in the tests
  • The new package is opened for reflection to JUnit 5 in module-info.java
  • The new package is listed in the contribution guide

Contributing

  • A prepared commit message exists
  • The list of contributions inside README.adoc mentions the new contribution (real name optional)

.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@Michael1993 Michael1993 added the full-build Triggers full build suite on PR label Jan 27, 2024
@Michael1993
Copy link
Member

Michael1993 commented Jan 28, 2024

It seems there is a difference between "uses-with-arguments" and "run" because the build fails when resolving input parameters. Could you look into that?

EDIT: Could be the difference between gradle and gradlew?

No, because the failing build is not one you changed, sorry.

@TWiStErRob

This comment was marked as resolved.

@TWiStErRob

This comment was marked as resolved.

@TWiStErRob

This comment was marked as resolved.

@TWiStErRob
Copy link
Contributor Author

Note: there was a weird random failure at https://github.com/junit-pioneer/junit-pioneer/actions/runs/7687474915/job/20947604357, never seen the like of it, I don't think it's related to this change. I reopened the PR to re-trigger and it "just worked": https://github.com/junit-pioneer/junit-pioneer/actions/runs/7688177222

@TWiStErRob

This comment was marked as resolved.

@TWiStErRob

This comment was marked as outdated.

@TWiStErRob TWiStErRob closed this Jan 29, 2024
@TWiStErRob TWiStErRob reopened this Jan 29, 2024
.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
@TWiStErRob
Copy link
Contributor Author

Reopening to trigger on stable.

@TWiStErRob TWiStErRob closed this Jan 31, 2024
@TWiStErRob TWiStErRob reopened this Jan 31, 2024
@TWiStErRob
Copy link
Contributor Author

Reopening to trigger again on stable,
GitHub Actions Runner internal errored:
https://github.com/junit-pioneer/junit-pioneer/actions/runs/7733227001?pr=803

@TWiStErRob TWiStErRob closed this Jan 31, 2024
@TWiStErRob TWiStErRob reopened this Jan 31, 2024
@Bukama
Copy link
Member

Bukama commented Feb 2, 2024

@TWiStErRob Please give a short comment, when you think you are done. I've lost the context due your close/reopen-trigger actions ;)

@TWiStErRob
Copy link
Contributor Author

TWiStErRob commented Feb 2, 2024

It's done, same as 5 days ago, the reopening is only a substitution for my inability to press "Rerun all jobs" on the GitHub UI to test newer and newer versions getting released.

@Michael1993 Michael1993 merged commit e9f160e into junit-pioneer:main Feb 6, 2024
123 of 124 checks passed
@TWiStErRob TWiStErRob deleted the setup-gradle branch February 6, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-build Triggers full build suite on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants