-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to setup-gradle@v3 #803
Conversation
It seems there is a difference between "uses-with-arguments" and "run" because the build fails when resolving input parameters. Could you look into that? EDIT: No, because the failing build is not one you changed, sorry. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
a63d959
to
3886ee8
Compare
Note: there was a weird random failure at https://github.com/junit-pioneer/junit-pioneer/actions/runs/7687474915/job/20947604357, never seen the like of it, I don't think it's related to this change. I reopened the PR to re-trigger and it "just worked": https://github.com/junit-pioneer/junit-pioneer/actions/runs/7688177222 |
3886ee8
to
d2c96f2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
Reopening to trigger on stable. |
Reopening to trigger again on stable, |
@TWiStErRob Please give a short comment, when you think you are done. I've lost the context due your close/reopen-trigger actions ;) |
It's done, same as 5 days ago, the reopening is only a substitution for my inability to press "Rerun all jobs" on the GitHub UI to test newer and newer versions getting released. |
Proposed commit message:
PR checklist
The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.
Documentation (general)
.adoc
file in thedocs
folder, e.g.docs/report-entries.adoc
.adoc
file references demo insrc/demo/java
instead of containing code blocks as text.adoc
files)Documentation (new extension)
docs/docs-nav.yml
navigation has an entry for the new extensionpackage-info.java
contains information about the new extensionCode (general)
Code (new package)
module-info.java
module-info.java
Contributing
README.adoc
mentions the new contribution (real name optional)