Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub actions to run on Node 20 #804

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

TWiStErRob
Copy link
Contributor

@TWiStErRob TWiStErRob commented Jan 28, 2024

Proposed commit message:

Update setup-java and cache actions from v3 to v4 to run on Node 20.
Update wrapper-validation-action from v1 to v2 to run on Node 20

Fixes CI warnings:

> Node.js 16 actions are deprecated.
> Please update the following actions to use Node.js 20:
> actions/wrapper-validation-action@v1, actions/setup-java@v3, actions/cache@v3.
> For more information see:
> https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

PR: #804

See warnings at https://github.com/junit-pioneer/junit-pioneer/actions/runs/7688177222


PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
  • Site documentation in .adoc file references demo in src/demo/java instead of containing code blocks as text
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Documentation (new extension)

  • The docs/docs-nav.yml navigation has an entry for the new extension
  • The package-info.java contains information about the new extension

Code (general)

  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks
  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)

Code (new package)

  • The new package is exported in module-info.java
  • The new package is also present in the tests
  • The new package is opened for reflection to JUnit 5 in module-info.java
  • The new package is listed in the contribution guide

Contributing

  • A prepared commit message exists
  • The list of contributions inside README.adoc mentions the new contribution (real name optional)

@TWiStErRob
Copy link
Contributor Author

Note: there will be other warnings showing up on this PR, those should be fixed by #803

@TWiStErRob TWiStErRob mentioned this pull request Jan 28, 2024
18 tasks
@TWiStErRob TWiStErRob changed the title Update setup-java from v3 to v4 to run on Node 20 Update setup-java and cache from v3 to v4 to run on Node 20 Jan 28, 2024
@TWiStErRob TWiStErRob changed the title Update setup-java and cache from v3 to v4 to run on Node 20 Update setup-java and cache actions from v3 to v4 to run on Node 20 Jan 28, 2024
@Michael1993 Michael1993 added the full-build Triggers full build suite on PR label Jan 28, 2024
@TWiStErRob

This comment was marked as resolved.

@TWiStErRob TWiStErRob changed the title Update setup-java and cache actions from v3 to v4 to run on Node 20 Update GitHub actions to run on Node 20 Jan 29, 2024
@Bukama Bukama merged commit b21e7b8 into junit-pioneer:main Feb 2, 2024
33 checks passed
@TWiStErRob TWiStErRob deleted the node20 branch February 7, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-build Triggers full build suite on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants