Merge pull request #7227 from tibdex/master

Only display node structure in JSONTree for arrays and empty objects
jupyterlab · Sep 25, 2019 · 12821a3 · 12821a3
2 parents d427440 + 47e11f9
commit 12821a3
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/packages/json-extension/src/component.tsx b/packages/json-extension/src/component.tsx
@@ -71,6 +71,17 @@ export class Component extends React.Component<IProps, IState> {
           }}
           invertTheme={false}
           keyPath={[root]}
+          getItemString={(type, data, itemType, itemString) =>
+            Array.isArray(data) ? (
+              // Always display array type and the number of items i.e. "[] 2 items".
+              <span>
+                {itemType} {itemString}
+              </span>
+            ) : Object.keys(data).length === 0 ? (
+              // Only display object type when it's empty i.e. "{}".
+              <span>{itemType}</span>
+            ) : null
+          }
           labelRenderer={([label, type]) => {
             // let className = 'cm-variable';
             // if (type === 'root') {