Skip to content

Commit

Permalink
Make pinned extension filename windows compat
Browse files Browse the repository at this point in the history
  • Loading branch information
saulshanabrook committed Aug 15, 2019
1 parent f269cc0 commit 93b08ca
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions jupyterlab/commands.py
Expand Up @@ -38,6 +38,9 @@
DEV_DIR = osp.abspath(os.path.join(HERE, '..', 'dev_mode'))


# If we are pinning the package, rename it `pin@<alias>`
PIN_PREFIX = 'pin@'

class ProgressProcess(Process):

def __init__(self, cmd, logger=None, cwd=None, kill_event=None,
Expand Down Expand Up @@ -1214,8 +1217,8 @@ def _get_extensions_in_dir(self, dname, core_data):
path = osp.abspath(target)

filename = osp.basename(target)
if filename.startswith("pin:"):
alias = filename[len("pin:"):-len(".tgz")]
if filename.startswith(PIN_PREFIX):
alias = filename[len(PIN_PREFIX):-len(".tgz")]
else:
alias = None
# homepage, repository are optional
Expand Down Expand Up @@ -1479,10 +1482,9 @@ def _extract_package(self, source, tempdir, pin=None):
info['path'] = target
else:
info['path'] = path
# If we are pinning the package, rename it `pin:<name>``
if pin:
old_path = info['path']
new_path = pjoin(osp.dirname(old_path), 'pin:{}.tgz'.format(pin))
new_path = pjoin(osp.dirname(old_path), '{}{}.tgz'.format(PIN_PREFIX, pin))
shutil.move(old_path, new_path)
info['path'] = new_path

Expand Down

0 comments on commit 93b08ca

Please sign in to comment.