Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't disable built-in Find bar #4730

Closed
basnijholt opened this issue Jun 14, 2018 · 7 comments
Closed

Can't disable built-in Find bar #4730

basnijholt opened this issue Jun 14, 2018 · 7 comments
Labels
documentation good first issue pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@basnijholt
Copy link

basnijholt commented Jun 14, 2018

I would like to completely disable the search bar that shows up when pressing Command + F:

I mean this one:
41129190-cbd83fa8-6a65-11e8-9872-9397d818f482

However, this doesn't seem to be possible from the shortcuts menu.

Is there a way to do this?

There is this related issue #2637

@basnijholt
Copy link
Author

I just learned that if you press ctrl-F twice, then it goes to the browser.

@blink1073 blink1073 added this to the Future milestone Sep 11, 2018
@jasongrout
Copy link
Contributor

Cool, I didn't know that! Let's change this issue to documenting this.

@jasongrout jasongrout changed the title Can't disable built-in Find bar Document how to get the browser Find Sep 11, 2018
@basnijholt
Copy link
Author

I think that should be another issue. It should still be possible to disable/change this behavior.

@jasongrout jasongrout changed the title Document how to get the browser Find Can't disable built-in Find bar Sep 11, 2018
@jasongrout
Copy link
Contributor

Okay, switching the title back, then.

@afshin afshin added DISC2018 and removed DISC2018 labels Oct 25, 2018
@jasongrout
Copy link
Contributor

To disable this, I think we'd need to (a) figure out the way to disable the searching in CodeMirror and (b) expose an option to the user to turn off searching.

At the very least, I think we should document the ctrl F twice way of getting past the codemirror search.

@aschlaep
Copy link
Member

@cquah has pointed out that this can probably be closed now that #5795 and subsequent ctrl+f PRs have merged!

@ian-r-rose
Copy link
Member

Fixed by #5795 and friends. Thanks @aschlaep!

@jasongrout jasongrout modified the milestones: Future, 1.0 Apr 27, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation good first issue pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

6 participants