Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark scheme: Improve code completion dropbox selector contrast #5349

Closed
alexveden opened this issue Sep 21, 2018 · 3 comments · Fixed by #5364
Closed

Dark scheme: Improve code completion dropbox selector contrast #5349

alexveden opened this issue Sep 21, 2018 · 3 comments · Fixed by #5364
Assignees
@tgeorgeux
Labels
good first issue help wanted pkg:completer status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Accessibility tag:Design and UX
Milestone
0.35

Comments

@alexveden
Copy link

Describe the bug
Could you please make more contrast selection row in code completion dropbox (at TAB press)?

image

  • OS: Ubuntu LTS 16.04
  • Browser Chrome Version 69.0.3497.100
  • JupyterLab 0.34.11
@blink1073 blink1073 added this to the 1.0 milestone Sep 21, 2018
@blink1073
Copy link
Member

Thanks for the report!

@Songyu-Wang Songyu-Wang mentioned this issue Sep 23, 2018
Merged
@tgeorgeux tgeorgeux self-assigned this Sep 26, 2018
@tgeorgeux
Copy link
Contributor

If on select we change the font color on focus to "--jp-ui-inverse-font-color1" it will show up more clearly.

@jasongrout
Copy link
Contributor

Would you mind adding this comment to the PR as a review comment: #5364 ?

tgeorgeux added a commit that referenced this issue Sep 28, 2018
@tgeorgeux
Merge pull request #5364 from Songyu-Wang/fix-#5349
1a9c434 
Fix issue #5349 by using a darker color as background when row selected
@jasongrout jasongrout modified the milestones: 1.0, 0.35 Sep 28, 2018
@blink1073 blink1073 mentioned this issue Sep 28, 2018
Closed
31 tasks
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tgeorgeux tgeorgeux

Labels
good first issue help wanted pkg:completer status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Accessibility tag:Design and UX
Projects
None yet
Milestone
0.35
Development

Successfully merging a pull request may close this issue.

Fix issue #5349 by using a darker color as background when row selected
5 participants
@afshin @jasongrout @blink1073 @alexveden @tgeorgeux