Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show kernel ID for notebooks and consoles in list view #16228

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gderocher
Copy link

References

#15991

Code changes

Added name() function to return the name of children (previously done by label).
Reimplemented label function to display kernel ID through a ReactNode.

User-facing changes

Kernel ID displays for all notebooks and consoles in both list and tree view.
Planning on updating so the ID only shows in list view.

After Changes:
image
image

Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link

welcome bot commented Apr 23, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@krassowski
Copy link
Member

Thanks for starting this @gderocher. To make it show up conditionally you will need to add something like:

.jp-mod-kernel-widget .jp-RunningSessions-item-label-kernel-id {
   display: none;
}

.jp-mod-running-list-view .jp-mod-kernel-widget .jp-RunningSessions-item-label-kernel-id {
   display: inline;
}

to packages/running/style/base.css

@krassowski
Copy link
Member

It also looks like this PR needs rebasing or merging with the main branch to resolve conflicts.

@krassowski krassowski changed the title [#15991] Implemented showing kernel ID for notebooks and consoles (Incomplete) Implemented showing kernel ID for notebooks and consoles Apr 25, 2024
@krassowski krassowski marked this pull request as draft April 25, 2024 10:04
@krassowski krassowski changed the title Implemented showing kernel ID for notebooks and consoles Showing kernel ID for notebooks and consoles in list view Apr 25, 2024
@krassowski krassowski changed the title Showing kernel ID for notebooks and consoles in list view Show kernel ID for notebooks and consoles in list view Apr 25, 2024
@krassowski krassowski added this to the 4.3.0 milestone Apr 26, 2024
@gderocher
Copy link
Author

We tried to merge the files with main and resolve the conflict, but it seems to be treating the commit as separate items. Let us know if we should create a new pull request, or if you have any ideas to fix it. Thank you.

@krassowski
Copy link
Member

I would suggest you try rebasing on main and force push to this PR.

@RyanWilson20
Copy link

Should have the merge all set now. Should we do anything to remove all the extra tags that got added in the mishap?

@krassowski
Copy link
Member

This looks like a problem with labeler - it should remove the labels automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment