Change the filebrowser home icon to a folder #6553
Conversation
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Putting on 1.0 for part of the design review, but of course could be bumped if we feel the change is not worth trying to get into 1.0. |
|
Related to the discussion we're having in #6207 , if we are going to call this file location out with text I think it may be a better idea to call that out as the name of the folder that is your root directory. It doesn't make sense to me to abstract an additional 'root' directory. |
|
I like your idea of a folder icon even better than using the word "Root" |
…rators This implements @tgeorgux’s design from jupyterlab#6207 The slight difference in this commit is that it also includes a final slash. This adds a bit to the visual complexity, but makes it much more clear that the final thing is a directory, and you should think about the full path as that directory, slash, something in the filebrowser list.
|
@tgeorgeux - what do you think? I added screenshots in the description. |
|
The one thing about using the folder icon is that it means there are three folder icons in close proximity that all mean something different: (file browser tab, add new folder, and server root folder). |
jasongrout
changed the title
There was a problem hiding this comment.
This looks mostly good to me. I suspect the "home" icon can be safely deleted from the theme packages.
I'll let @ellisonbg or @tgeorgeux make the final call on the design.
|
Merging since the design came from @tgeorgeux. @ellisonbg, if you have any concerns, let's address it in another PR. |
|
(the one concern I have is that the folder icon is being used in three different places in close proximity with different meanings) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion. |
jasongrout
added
the
status:resolved-locked
References
See #6539
Code changes
User-facing changes
Changes the home icon in the filebrowser to be a folder icon and use slash as separators. Some thoughts around this are in #6539
Backwards-incompatible changes