Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vega downloads and download URLs in general #7022

Merged
merged 2 commits into from Aug 16, 2019
Merged

Fix Vega downloads and download URLs in general #7022

merged 2 commits into from Aug 16, 2019

Commits on Aug 15, 2019

  1. Fix getDownloadURL to properly append the xsrf token without a slash. 

    Before, we would get URLs like http://example.com/files/file.txt/?_xsrf=token, and now the slash after file.txt is eliminated.
    @jasongrout
    jasongrout committed Aug 15, 2019
    Copy the full SHA
    588fa5e View commit details
    Browse the repository at this point in the history

  2. Make vega extensions use getDownloadUrl to retrieve files from the se… 

    …rver.

Perhaps we should also use the services package to actually send the request to the server. That would complicate these plugins beyond simple rendermime plugins, though.

Fixes jupyterlab#7017
    @jasongrout
    jasongrout committed Aug 15, 2019
    Copy the full SHA
    70ac6fa View commit details
    Browse the repository at this point in the history