Fix baseURL in vega extensions #7047 #7048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the path of the current notebook is included in the URL for data files in the vega extensions.
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
After testing this again this isn't working for me and I don't know why I thought it was working. Sorry for the noise. |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the path of the current notebook is included in the
URL for data files in the vega extensions.
This adds the baseURL back into the vega loaders which allows notebooks
running in subdirectories to properly load files. With the addition of
the sanitizing of urls in #7022 there are no longer the issues seen in
#7017 where the _xsrf token was placed in the middle of the URL.
References
Fixes #7047
See also #7017 and #7022 / #7031
Code changes
The vega loader includes the baseURL once again so it knows about the current directory of the current notebook.
User-facing changes
This changes the behaviour back to what existed in version 1.0.2
Backwards-incompatible changes
None