Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix baseURL in vega extensions #7047 #7048

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/vega4-extension/src/index.ts
Expand Up @@ -92,7 +92,10 @@ export class RenderedVega extends Widget implements IRenderMime.IRenderer {
this._result.view.finalize();
}

const path = await this._resolver.resolveUrl('');
const baseURL = await this._resolver.getDownloadUrl(path);
const loader = vega.vega.loader({
baseURL,
http: { credentials: 'same-origin' }
});

Expand Down
3 changes: 3 additions & 0 deletions packages/vega5-extension/src/index.ts
Expand Up @@ -92,7 +92,10 @@ export class RenderedVega extends Widget implements IRenderMime.IRenderer {
this._result.view.finalize();
}

const path = await this._resolver.resolveUrl('');
const baseURL = await this._resolver.getDownloadUrl(path);
const loader = vega.vega.loader({
baseURL,
http: { credentials: 'same-origin' }
});
const sanitize = async (uri: string, options: any) => {
Expand Down