Backport PR #7192: progress on icons: added inline svg icon support to toolbar buttons #7236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… support to toolbar buttons (cherry picked from commit 0a989e6)
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Backports #7192 to 1.1.x
Code changes
User-facing changes
Backwards-incompatible changes
This is technically backwards incompatible at the CSS level, but it will fix a number of issues people are running into with 1.0.2 (see #7192 for links), so we consider backporting and releasing the lesser of two evils here.