New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework kernel and session architecture #7252
Merged
Merged
Changes from all commits
Commits
Show all changes
100 commits
Select commit
Hold shift + click to select a range
374ecb1
Simplify async logic by using an async anonymous function.
jasongrout a894cb1
wip
jasongrout 1faae20
Update kernel status to have a connection status and a kernel status.
jasongrout 94ad719
Fix many test failures.
jasongrout 597f973
Updated session to proxy the connection status from the kernel.
jasongrout 974ef17
Delete unnecessary awaits for kernel info replies.
jasongrout 924f4fe
Rework session and clientsession status to just point to the kernel s…
jasongrout 4d9d022
Document an overview of the client session / session / kernel archite…
jasongrout 74071d0
Refactor validation functions
jasongrout 72ea9e9
Move kernel spec functionality to its own module, with its own manage…
jasongrout 9efd678
Factor out common things from the managers into a base manager.
jasongrout a287b4f
Change session kernel changed signal to be a real IChangedArgs signal.
jasongrout 8c1b436
Use kernel status directly instead of session status.
jasongrout 9746a65
Move kernel rest api communication to new restapi module and caching …
jasongrout cd5d04a
WIP update session to mirror new kernel refactoring.
jasongrout ae82116
WIP update for session manager
jasongrout 1b3a37b
Refactor connection construction options and various places models ar…
jasongrout 8cc4100
WIP
jasongrout 03572e3
Fix remaining compile errors in services package
jasongrout 7482b34
Update services to use new TS 3.7 null coalescing and optional chaini…
jasongrout a3bae85
Use ts 3.7 assertion functions to improve typing.
jasongrout 3a5ae0b
Update core plugins for the changes in services and ClientSession.
jasongrout 96f89b2
Clean up a few more changes we’ve made.
jasongrout 483c056
More correctly use the status in change signals in clientsession.
jasongrout 7410373
WIP clean up tests and kernel starting signatures
jasongrout 1c04505
Reorganize kernelspec and kernel modules to use modules instead of na…
jasongrout 79c84cb
Update services tests and fix relevant bugs.
jasongrout 0e435b2
Export kernel spec rest api
jasongrout b447b80
wip
jasongrout 5293cd3
wip
jasongrout 50701f7
Rename clientsession files to sessioncontext
jasongrout cc192f0
Clean up documentation and api for session context
jasongrout 6d7e69c
Clean up kernel api
jasongrout d8724f5
Change status bar code to indicate kernel sessions, not just kernels
jasongrout 21e1b88
Update completers to handle session changes
jasongrout 77b0890
More API and docs cleanup.
jasongrout fae3c37
Fix lots of tests
jasongrout c5dcf16
Trigger ‘restarting’ status ourselves when we initiate the kernel res…
jasongrout f071fc3
Fix more tests
jasongrout deed221
Rewrite some of the sessionContext logic as async/await and fix tests.
jasongrout 43718a3
Work through tricky logic around disposing dead kernel connections.
jasongrout da2fcb0
Fix almost all of the services tests.
jasongrout be9ea01
Fix session context tests
jasongrout b9e7aff
Fix the kernel toolbar indicator to show the kernel connection status…
jasongrout 5075531
Fix rendermime tests
jasongrout 39b4471
Add more testing options for comprehensive running tests
jasongrout 00d756a
Add initialize and ready/isReady methods to session context.
jasongrout 516f741
overhaul the test createFileContext utility functions
jasongrout 3ad329e
Fix more tests.
jasongrout f93c404
Fix remaining failing tests.
jasongrout b8de3a6
Merge branch 'master' into sessionpersistence
jasongrout 55138af
Fix compile errors
jasongrout 338317f
Remove the sessionContext.kernel convenient shortcut.
jasongrout 55317db
Clean up comments and formatting.
jasongrout 19c44df
Make status bar explicitly and accurately have a tooltop of “kernel s…
jasongrout 8722b89
Fix linting errors
jasongrout 6de2dfc
Fix tests
jasongrout 985dcf6
Fix tests
jasongrout 624d49b
Fix building examples
jasongrout 1943ff5
Take care of some TODOs that are no longer applicable.
jasongrout 3be3916
Clean up some old TODOs
jasongrout 9e044b3
Change kernel.connectComm to kernel.createComm and add a new hasComm …
jasongrout b97ec47
Allow reconnections for disconnected kernels
jasongrout 1a2dde3
Only try to reconnect if the kernel connection is not disposed
jasongrout 5250848
Delete old test comment
jasongrout b8f2a21
Update testEmission to use optional chaining and null coalescing.
jasongrout 1147fb4
Fix skipped test
jasongrout 2ff170e
Fix some problematic logic around reconnections exposed by the tests
jasongrout b12665f
Fix comm test
jasongrout a3ee507
Test sessionContext shutdownOnDispose
jasongrout a0930fd
Clean out more TODO notes.
jasongrout 8a5712d
Change .getSpec() to just .spec, to mirror the .info promise.
jasongrout 06c4251
Resolve another TODO item by deciding against it.
jasongrout 49b96ae
Make the session and kernel interfaces more consistent
jasongrout 947a00c
Fix kernel connection spec promise calls.
jasongrout 3334567
Fix a few more tests from the session manager signature changes.
jasongrout 897635c
Another pass updating the services readme.
jasongrout bebcf00
Separate out the kernel and session creation vs connection options in…
jasongrout e751b95
Make slots class methods since we are now passing in the `this` conte…
jasongrout 76a15dc
Restore original jest timeouts.
jasongrout e2ea578
Add connectionStatusChanged signal to session context.
jasongrout e999cf1
Remove debug logging.
jasongrout f4ff2af
Add a convenience session context .kernelDisplayStatus
jasongrout 8d8b069
Fix an error where the handler used a variable before it was declared.
jasongrout 11b86ee
Merge remote-tracking branch 'origin/master' into sessionpersistence
jasongrout 9202a78
Fix compile issues from a mis-merge.
jasongrout e6f0a24
Merge remote-tracking branch 'origin/master' into sessionpersistence
jasongrout 1fa189e
Remove obsolete test
jasongrout 8635f64
Linting fixes
jasongrout 0ad63f3
When creating a test session context, make sure the spec manager is r…
jasongrout 7a8e4bb
Explicitly test kernel preference starting values to have the right d…
jasongrout dd5310e
Fix usage examples.
jasongrout bb0bd2c
Add tests for session context kernelDisplayName and kernelDisplayStatus
jasongrout 7bbc7e8
Move example code for services into tested files.
jasongrout 634f440
Service manager ready should depend on kernelspec manager ready.
jasongrout 446f056
Add some more documentation to the services readme.
jasongrout ab45e19
[skip ci] spelling
d2cee9c
Streamline test that often times out on Windows and raise timeout limit
jasongrout 967180f
Merge branch 'sessionpersistence' of github.com:jasongrout/jupyterlab…
jasongrout f18e0fd
Up timeouts on tests we seem to be getting timeouts on in the windows…
jasongrout File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!