Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up log console api a bit #7379

Merged
merged 42 commits into from
Oct 22, 2019
Merged

Clean up log console api a bit #7379

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
9bc63f1
Change log console activeSource to just source
jasongrout Oct 15, 2019
da0e950
Make log console creation options include layout and source.
jasongrout Oct 16, 2019
38db0bc
Change toolbar buttons to command buttons so they can be disabled eas…
jasongrout Oct 17, 2019
2afb2ae
Handle attached signals with show/hide messages instead
jasongrout Oct 17, 2019
177f20f
Add a sourceChanged signal and use it to notify of command changes.
jasongrout Oct 17, 2019
6532dfa
Simplify logic for switching the log console source.
jasongrout Oct 17, 2019
04e60cc
Simplify react rendering logic slightly.
jasongrout Oct 17, 2019
c8c20a5
Factor out the log console status bar component to a separate module.
jasongrout Oct 17, 2019
d6e9e79
Make the info colors consistent with usage elsewhere in JLab.
jasongrout Oct 17, 2019
341782f
Activate log console widget through the shell.
jasongrout Oct 17, 2019
db23c4d
Make more dependencies optional
jasongrout Oct 17, 2019
2da6a4b
Push the max log size down to the model
jasongrout Oct 17, 2019
2105a18
Populate console on attachment
jasongrout Oct 17, 2019
75f66d1
Fix status bar flashing state when log console is created.
jasongrout Oct 17, 2019
6aa7beb
Simplify the status bar components
jasongrout Oct 18, 2019
8fd895e
Change log console highlight to use brand color.
jasongrout Oct 18, 2019
540c4c0
Track whether a log has ever had a message, and hide the status bar w…
jasongrout Oct 18, 2019
6188897
Override the typestyle font color when log console status bar item is…
jasongrout Oct 18, 2019
f8ddaec
Move list icon to ui-components package.
jasongrout Oct 18, 2019
abe11d0
Use the new icon system for log console.
jasongrout Oct 18, 2019
4407953
Add a log console plugin to log all notebook outputs.
jasongrout Oct 18, 2019
fbfd865
Exploration for how to communicate to the right components that curre…
jasongrout Oct 18, 2019
da58234
Revert "Exploration for how to communicate to the right components th…
jasongrout Oct 18, 2019
3638e3c
Refactor logger and registry into separate files.
jasongrout Oct 18, 2019
e2bd8d7
Clean up typo and unused code.
jasongrout Oct 18, 2019
60cf63d
Add a scrolling widget.
jasongrout Oct 19, 2019
a0fc42b
Fix the scrolling widget to work well.
jasongrout Oct 19, 2019
6c41ec0
Move the scrolling widget back to the LogConsolePanel.
jasongrout Oct 19, 2019
60b66ad
Fix tracking of scroll position across toggling consoles.
jasongrout Oct 19, 2019
22b1302
Clean up ScrollWidget typings
jasongrout Oct 19, 2019
050080f
Set up a system for log versions that enables notification and displa…
jasongrout Oct 19, 2019
0dd9522
Fix scrolling widget initial display to scroll to bottom.
jasongrout Oct 19, 2019
f62efaf
Fix an initial log console rendering with no source.
jasongrout Oct 19, 2019
0f436d4
Add todo
jasongrout Oct 19, 2019
5c6d18c
Do more careful handling of null sources.
jasongrout Oct 19, 2019
d52227d
Delete unnecessary todo
jasongrout Oct 19, 2019
3fb09a5
Carefully account for message display to fix bugs and remove unnecess…
jasongrout Oct 20, 2019
9bde66c
Reorder code to follow JLab guidelines
jasongrout Oct 20, 2019
7dbf2cc
Add todo item about the notebook output logger.
jasongrout Oct 20, 2019
5c27453
Integrity fix
jasongrout Oct 20, 2019
f34ca0d
Fix log console tab icon
jasongrout Oct 22, 2019
0d4115d
Remove notebook output logging.
jasongrout Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/logconsole-extension/package.json
View file
Open in desktop
Expand Up @@ -41,7 +41,9 @@
"@jupyterlab/notebook": "^2.0.0-alpha.1",
"@jupyterlab/rendermime": "^2.0.0-alpha.1",
"@jupyterlab/statusbar": "^2.0.0-alpha.1",
"@phosphor/messaging": "^1.3.0",
"@phosphor/signaling": "^1.3.0",
"@phosphor/widgets": "^1.9.0",
"react": "~16.8.4"
},
"devDependencies": {
Expand Down