Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure label is linked to a control when checking for element type #7458

Merged
merged 2 commits into from Dec 12, 2019
Merged

Make sure label is linked to a control when checking for element type #7458

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1a112c
make sure label is linked to a control
mbektas Nov 1, 2019
2e9182b
check if label for attribute defined
mbektas Nov 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/apputils/src/toolbar.tsx
View file
Open in desktop
Expand Up @@ -327,8 +327,12 @@ export class Toolbar<T extends Widget = Widget> extends Widget {
* Handle a DOM click event.
*/
protected handleClick(event: Event) {
// Clicking a label focuses the corresponding control, so let it be.
if (event.target instanceof HTMLLabelElement) {
// Clicking a label focuses the corresponding control
// that is linked with `for` attribute, so let it be.
if (
event.target instanceof HTMLLabelElement &&
this.node.querySelector(`#${event.target.getAttribute('for')}`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add && event.target.getAttribute('for') to check if it is undefined?

) {
return;
}

Expand Down