Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to TypeScript 3.7 #7522

Merged
merged 5 commits into from Nov 15, 2019
Merged

Upgrade to TypeScript 3.7 #7522

merged 5 commits into from Nov 15, 2019

Commits on Nov 14, 2019

  1. Copy the full SHA
    6bfe84f View commit details
    Browse the repository at this point in the history
  2. Disable type checking vega-lite libraries.

    Typscript 3.7 throws some errors when compiling Vega-lite 2 and 3, so we turn off lib checks.
    
    This was investigated much more deeply in jupyterlab#7428, where we deleted the vega 4 extension and upgraded the vega 5 extension to vega-lite 4.0b11. The vega-lite upgrade was not going smoothly, so we moved it to a separate issue and redid the Typescript upgrade by just using the skipLibCheck flag.
    jasongrout committed Nov 14, 2019
    Copy the full SHA
    4029c13 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. Update typedoc to 0.15.2

    jasongrout committed Nov 15, 2019
    Copy the full SHA
    c4a752e View commit details
    Browse the repository at this point in the history
  2. Migrate typedoc config to more conventional typedoc.json files

    This does not build coreutils docs because it complains about the .json file that is imported. This is probably a typescript or a typedoc bug.
    jasongrout committed Nov 15, 2019
    Copy the full SHA
    afe04d6 View commit details
    Browse the repository at this point in the history
  3. Work around bug in giving include files and having composite true

    For some reason, typescript itself works fine, but typedoc has this error:
    
     File ‘[snip]/jupyterlab/packages/coreutils/src/plugin-schema.json' is not listed within the file list of project ''. Projects must list all files or use an 'include' pattern.
    
    This avoids this issue somehow by setting composite to false for typedoc doc builds.
    jasongrout committed Nov 15, 2019
    Copy the full SHA
    cabe2ea View commit details
    Browse the repository at this point in the history