Continuation of Allow shortcuts to be empty and to have win/mac/linux-specific keys #7581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Continues #7335
Code changes
This PR removes jupyterlab checks for empty shortcuts allowing phosphor to handle platform specific keyboard shortcuts.
User-facing changes
Users can define platform specific shortcuts as follows:
Note that the "keys" list is still required, but can be empty now. As referenced in #7335, this allows phosphor to use "linuxKeys", "winKeys", or "macKeys" depending on the platform.
Backwards-incompatible changes