Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow platform aware key shortcuts #7589

Merged
merged 14 commits into from Dec 23, 2019
Merged

Allow platform aware key shortcuts #7589

merged 14 commits into from Dec 23, 2019

Commits on Dec 4, 2019

  1. Normalize keys taking in a platform aware way. 

    Normalizing keys will return a list of shortcuts available for the
running platform (so platform specific keys + keys).  Process that
normalized list instead of the shortcut keys directly.

This means that winKeys, linuxKeys, and macKeys are properly supported
in jupyterlab shortcuts.
    @groutr
    groutr committed Dec 4, 2019
    Copy the full SHA
    0e47b33 View commit details
    Browse the repository at this point in the history

  2. Allow shortcuts to be empty and to have win/mac/linux-specific keys. 

    Phosphor allows shortcuts to be empty, and it’s the only way to have platform-specific shortcuts (define keys to be [], and the platform keys to be something specific).

See phosphorjs/phosphor#438 for some discussion.
    @jasongrout @groutr
    jasongrout authored and groutr committed Dec 4, 2019
    Copy the full SHA
    a85feb3 View commit details
    Browse the repository at this point in the history

  3. Fix wording of warning messages.

    @groutr
    groutr committed Dec 4, 2019
    Copy the full SHA
    748ac19 View commit details
    Browse the repository at this point in the history

  4. Reorganize shortcuts documentation for clarity.

    @groutr
    groutr committed Dec 4, 2019
    Copy the full SHA
    af97ff0 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. Merge branch 'master' into platformshortcuts

    @groutr
    groutr committed Dec 10, 2019
    Copy the full SHA
    ad40e24 View commit details
    Browse the repository at this point in the history

  2. Use normalizeKeys from lumino/commands.

    @groutr
    groutr committed Dec 10, 2019
    Copy the full SHA
    0125bdf View commit details
    Browse the repository at this point in the history

  3. Upgrade @lumino/commands

    @groutr
    groutr committed Dec 10, 2019
    Copy the full SHA
    f637e72 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. Update yarn.lock 

    Upate @lumino/commands.
    @groutr
    groutr committed Dec 11, 2019
    Copy the full SHA
    cefdaa4 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2019

  1. Update @lumino/commands.

    @groutr
    groutr committed Dec 12, 2019
    Copy the full SHA
    689d762 View commit details
    Browse the repository at this point in the history

  2. Package integrity updates

    @groutr
    groutr committed Dec 12, 2019
    Copy the full SHA
    44b4f04 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into platformshortcuts

    @groutr
    groutr committed Dec 12, 2019
    Copy the full SHA
    7032827 View commit details
    Browse the repository at this point in the history

  4. Update @lumino/commands (try 3)

    @groutr
    groutr committed Dec 12, 2019
    Copy the full SHA
    7675ea2 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2019

  1. Merge branch 'master' into platformshortcuts

    @groutr
    groutr committed Dec 16, 2019
    Copy the full SHA
    0a50bbf View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2019

  1. Merge remote-tracking branch 'origin/master' into pr/groutr/7589

    @jasongrout
    jasongrout committed Dec 23, 2019
    Copy the full SHA
    fb2a273 View commit details
    Browse the repository at this point in the history