Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Change ConsolePanel to MainAreaWidget<ConsolePanel> #7645

Merged
merged 1 commit into from Dec 18, 2019
Merged

[WIP] Change ConsolePanel to MainAreaWidget<ConsolePanel> #7645

merged 1 commit into from Dec 18, 2019

Conversation

KsavinN
Copy link
Contributor

@KsavinN KsavinN commented Dec 18, 2019

References

resolve issue #7624

PR working with @afshin

Code changes

Change in console extension from ConsolePanel to MainAreaWidget.

The reason was to have in ConsolePanel typical MainAreaWidget content like a toolbar.

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@KsavinN KsavinN changed the title Change ConsolePanel to MainAreaWidget<ConsolePanel> [WIP-work in progress] Change ConsolePanel to MainAreaWidget<ConsolePanel> Dec 18, 2019
@KsavinN KsavinN changed the title [WIP-work in progress] Change ConsolePanel to MainAreaWidget<ConsolePanel> Change ConsolePanel to MainAreaWidget<ConsolePanel> Dec 18, 2019
@KsavinN KsavinN changed the title Change ConsolePanel to MainAreaWidget<ConsolePanel> [WIP] Change ConsolePanel to MainAreaWidget<ConsolePanel> Dec 18, 2019
blink1073
blink1073 approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073 blink1073 merged commit 5a9dd32 into jupyterlab:master Dec 18, 2019
@blink1073 blink1073 added this to the 2.0 milestone Dec 18, 2019
@blink1073
Copy link
Member

And congratulations on your first contribution to this repo!

@jasongrout jasongrout mentioned this pull request Dec 18, 2019
Closed
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 17, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KsavinN @blink1073