Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict nulls for everything except logconsole #7657

Merged
merged 16 commits into from Dec 23, 2019
Merged

Strict nulls for everything except logconsole #7657

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0bdce26
Fix lint commands for windows
vidartf Dec 19, 2019
479815c
Update to lumino/commands 1.9
vidartf Dec 20, 2019
df0b0f7
Turn on strict null checks (except for services)
vidartf Dec 20, 2019
98e2a16
Add generic arg to IChangeArgs helper
vidartf Dec 20, 2019
db21fd2
Simple typings changes for strict nulls
vidartf Dec 20, 2019
a9efefe
Might supress wanted errors
vidartf Dec 20, 2019
f5019d8
non-null asserts
vidartf Dec 20, 2019
51f9943
Vdom always has model
vidartf Dec 20, 2019
fed1b82
dispose
vidartf Dec 20, 2019
4569342
Logic changes
vidartf Dec 20, 2019
56bbec9
More partial types
vidartf Dec 20, 2019
cf623f1
misc uncertainties
vidartf Dec 20, 2019
e84817e
Strict nulls for services
vidartf Dec 20, 2019
d5995b2
integrity
vidartf Dec 20, 2019
3238bf4
Fixes for default value of session clientId
vidartf Dec 21, 2019
1b3930d
Clean up some tests
vidartf Dec 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/codemirror-extension/src/index.ts
View file
Open in desktop
Expand Up @@ -348,7 +348,7 @@ function activateEditorCommands(
}
modeMenu.addItem({
command: CommandIDs.changeMode,
args: { ...spec }
args: { ...spec } as any // TODO: Casting to `any` until lumino typings are fixed
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xref this comment: jupyterlab/lumino#32 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR: jupyterlab/lumino#33

});
});

Expand Down
5 changes: 4 additions & 1 deletion packages/completer/src/model.ts
View file
Open in desktop
Expand Up @@ -482,7 +482,10 @@ namespace Private {
export function findOrderedTypes(typeMap: Completer.TypeMap): string[] {
const filtered = Object.keys(typeMap)
.map(key => typeMap[key])
.filter(value => value && !(value in KNOWN_MAP))
.filter(
(value: string | null): value is string =>
!!value && !(value in KNOWN_MAP)
)
.sort((a, b) => a.localeCompare(b));

return KNOWN_TYPES.concat(filtered);
Expand Down
4 changes: 2 additions & 2 deletions packages/settingeditor/src/pluginlist.tsx
View file
Open in desktop
Expand Up @@ -53,8 +53,8 @@ export class PluginList extends Widget {
/**
* The selection value of the plugin list.
*/
get scrollTop(): number {
return this.node.querySelector('ul').scrollTop;
get scrollTop(): number | undefined {
return this.node.querySelector('ul')?.scrollTop;
}

/**
Expand Down