Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more careful about sessioncontext kernelChanged and sessionChanged signal emissions #7694

Merged
merged 3 commits into from Dec 29, 2019
Merged

Be more careful about sessioncontext kernelChanged and sessionChanged signal emissions #7694

merged 3 commits into from Dec 29, 2019

Commits on Dec 24, 2019

  1. Be more careful about sessioncontext kernelChanged and sessionChanged… 

    … signal emisssions

Fixes jupyterlab#7690
    @jasongrout
    jasongrout committed Dec 24, 2019
    Copy the full SHA
    3048d17 View commit details
    Browse the repository at this point in the history

  2. More careful sessioncontext dispose logic

    @jasongrout
    jasongrout committed Dec 24, 2019
    Copy the full SHA
    75c4e4b View commit details
    Browse the repository at this point in the history

  3. Save the intended console path, preventing doubling of consoles each … 

    …refresh.

Before, the save would happen before the session was created, which meant that the args values would be undefined, so new consoles would be created on refresh, plus the existing sessions would be displayed, doubling the number of consoles every refresh.

Fixes jupyterlab#7693
    @jasongrout
    jasongrout committed Dec 24, 2019
    Copy the full SHA
    303abb4 View commit details
    Browse the repository at this point in the history