Fixes lint-on-commit hook #7708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Now it is back to the old behavior where only nix gets lint on commit. |
|
@vidartf I'm on it |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, lint-on-commit is broken; no files ever get linted, and then the integrity CI check complains. It turns out that the glob pattern given in the
.lintstagedrcdoesn't match any files. It looks like @vidartf made the relevant change in 0bdce26 as part of #7657. The commit msg from 0bdce26 suggests that the changes were made with the goal of Windows compatibility.This PR has the fix needed to get the lint hook working for me (OS X 10.14). Could someone with Windows please also test this PR?